Skip to content

Misc fixes #307

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
theyoyojo merged 3 commits into from
Dec 4, 2025
Merged

Misc fixes #307

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
9eb6455
orbit: radius: remove javascript from logout button
charliemirabile Dec 3, 2025
4a7b935
orbit: radius: reveal detailed feedback exactly on the deadline
charliemirabile Dec 3, 2025
afd136a
orbit: radius: add cache control header to login
charliemirabile Dec 4, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 4 additions & 3 deletions orbit/radius.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -296,8 +296,8 @@ def mk_form_welcome(session):
</div>
</div>
<div class="logout_buttons">
<form id="logout">
<input class="logout" type="button" onclick="location.href='/logout';" value="Logout" />
<form id="logout" method="get" action="/logout">
<input class="logout" type="submit" value="Logout" />
</form>
</div>'''

Expand All @@ -321,6 +321,7 @@ def login_form(target_location=None):


def handle_login(rocket):
rocket.headers += [('Cache-Control', 'no-cache')]
target = rocket.queries_query('target')

# harden the redirect to prevent csrf type attacks
Expand Down Expand Up @@ -463,7 +464,7 @@ def get_automated_feedback(self, attr):
case 'final':
due_date = int(self.assignment.final_due_date)

if due_date < int(datetime.now().timestamp()):
if due_date <= int(datetime.now().timestamp()):
return gbl.auto_feedback

match gbl.auto_feedback[-1]:
Expand Down