Misc fixes #307
Merged
Misc fixes #307
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We wanted to create a website without javascript but we used an `onclick` handler that modifies `location.href` in order to navigate to `/logout` when clicking the logout button. Instead, just make the button submit a form that performs GET on `/logout`. This makes logging out possible within e.g. `lynx` (currently the button does nothing an a message indicating that the button is unsupported is displayed).
Right now the second count needs to increment after the deadline passes before the feedback is revealed when in fact the border should be right when the second of the deadline starts. Fix by switching from `<` to `<=`. This should also make CI less flaky since even though we wait for the processing to finish, if it is started early within a given second and finishes within that second and the curl is able to run it might be able to catch the old generic feedback before the second advances and the detailed feedback is revealed.
Lynx aggressively caches pages which means that an outdated version of the login page might be displayed (showing the user as logged in when they aren't or vice versa). Use `Cache-Control: no-cache` which makes lynx not store the page and always fetch it. (Technically no-store would be better, but I don't think lynx recognizes it)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove only instance of JS on website I am aware of, and slightly tweak when feedback is revealed to hopefully make CI less flaky.