Submission tests to greatly pinp our CI #297
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
theyoyojo
force-pushed
the
submission_test_good_fixed_correct_branch_pls_merge
branch
5 times, most recently
from
3c16928 to
c8462ba
Compare
charliemirabile
requested changes
Sep 25, 2025
Contributor
charliemirabile
left a comment
charliemirabile
left a comment
There was a problem hiding this comment.
wondering if it even makes sense to have 4 different scripts, any reason not to just fold all of the new stuff into the existing test.sh? like I think maybe the main reason you wrote it that way is because we don't use podman-compose up or podman-compose down in the test.sh and you wanted to just write these tests from a blank slate, but could we modify the tests now that they are more crystalized to just work with the existing testing code?
theyoyojo
force-pushed
the
submission_test_good_fixed_correct_branch_pls_merge
branch
7 times, most recently
from
5da69eb to
181252b
Compare
theyoyojo
force-pushed
the
submission_test_good_fixed_correct_branch_pls_merge
branch
2 times, most recently
from
370c1d8 to
fa1d5bc
Compare
theyoyojo
changed the title
denis prints a message when the submissions are released for an assignment, i.e. when the deadline handler is triggered. This represents the system making the assignment emails available for viewing by qualified students. After this action is taken, denis updates the git tags in the grading repo and runs automated checks on the gradable submissions. Move the message to the end of the handler and rephrase it appropriately. Signed-off-by: Joel Savitz <joel@underground.software>
This isn't comprehensive but it's certainly an improvement. Signed-off-by: Joel Savitz <joel@underground.software>
This value is the same Message-ID that the client sees when sending the message with e.g. git-send-email. Our SMTP server saves this in a different header, X-KDLP-Orig-Message-ID, so retrieve it from there. Signed-off-by: Joel Savitz <joel@underground.software>
theyoyojo
force-pushed
the
submission_test_good_fixed_correct_branch_pls_merge
branch
from
2af0f84 to
9abf528
Compare
Closed
Release the Epstein files Fixes #281 Signed-off-by: Joel Savitz <joel@underground.software>
theyoyojo
force-pushed
the
submission_test_good_fixed_correct_branch_pls_merge
branch
from
9abf528 to
5b2c003
Compare
charliemirabile
approved these changes
Oct 5, 2025
Contributor
charliemirabile
left a comment
charliemirabile
left a comment
There was a problem hiding this comment.
good start, important to merge even if not perfect.
charliemirabile
deleted the
submission_test_good_fixed_correct_branch_pls_merge
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a bunch of new tests to exercise submission codepaths and workflow
Fixes #281
Also doubles as documentation