Submission tests #279
Closed
Submission tests #279
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Setup the submissions repo and go through the entire patchset submission process, exercising all return paths of mailman/patchset.py Includes intitial, peer review, and final submissions Signed-off-by: Joel Savitz <joel@underground.software>
This script the project in a more integration-test-like manner. Signed-off-by: Joel Savitz <joel@underground.software>
test-sub.sh is good for interactive testing, but lacks validation when automated. Add test-sub-check.sh to run some basic checks that make sure test-sub.sh ran smoothly. Signed-off-by: Joel Savitz <joel@underground.software>
We use podman around these parts Signed-off-by: Joel Savitz <joel@underground.software>
test.sh and test-sub-check.sh now source test-lib script-lint.sh modified to follow source commands for those two files. Signed-off-by: Joel Savitz <joel@underground.software>
Add test-sub2.sh which tests out 12 invalid and 1 valid submission on a rubric for an example coding assignment and validate the resulting status values added to the email ID tags in the grading repo. Simplify the new tests by abstracting the setup section and repetitive commands, enabling quicker development of shorter future testing scripts the same flavor as the rest of test-sub*.sh. This is important as we want to make sure our automated grading features actually do what we think they will do to the fullest extent possible before this code goes into production with real students. Signed-off-by: Joel Savitz <joel@underground.software>
theyoyojo
force-pushed
the
submission_tests
branch
from
833cf1c to
b8b8981
Compare
If a student makes an inital submission but not a final submission, they should automatically receive a zero for the assignment. Signed-off-by: Joel Savitz <joel@underground.software>
Check that total score is calculated correctly when only two students submit and only one review is required or no students submit so no reviews are required. Signed-off-by: Joel Savitz <joel@underground.software>
CI now runs the containers as a non-root user and exposes 1465 for SMTP instead of 465 Signed-off-by: Joel Savitz <joel@underground.software>
Signed-off-by: Joel Savitz <joel@underground.software>
Remove assignment rubric specificiation when invoking create_lighting_assignment since the feature is deferred to 0.8 Signed-off-by: Joel Savitz <joel@underground.software>
Signed-off-by: Joel Savitz <joel@underground.software>
Signed-off-by: Joel Savitz <joel@underground.software>
theyoyojo
force-pushed
the
submission_tests
branch
from
ac40ef9 to
5e09836
Compare
charliemirabile
force-pushed
the
master
branch
from
a073252 to
1a225dd
Compare
charliemirabile
requested changes
Sep 16, 2025
Contributor
charliemirabile
left a comment
charliemirabile
left a comment
There was a problem hiding this comment.
its squashin time
| write_commit_to "def" bob/setup/work "append" | ||
| write_commit_to "ghi" bob/setup/work "append" | ||
| git format-patch --rfc --cover-letter -v1 -3 | ||
| git format-patch --rfc --cover-letter -v2 -3 |
Contributor
There was a problem hiding this comment.
squash into relevant commit
Contributor
Author
|
Superseded by: #297 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a bunch of new tests to exercise submission codepaths and workflow
Fixes #281