-
Notifications
You must be signed in to change notification settings - Fork 4
Parse tower #278
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Parse tower #278
Conversation
fix formatting of digit number in value
I don't have a hard opinion on those topics as I feel like I can't really picture the consequences right now to be honest |
|
So as it currently stands, it would interpret
Instead it should probably reject (some of) these examples (skipping just enough) and see this instead
The second and third ones seem clear to me, that they should change, as factorial comes before multiplication and in the second one it is rendered (on at least some platforms) with the factorial in the exponent. The first and fourth I feel should also be changed, as I think (sub-)factorial comes before power/tetration/etc. |
fix pre op on tower fix pre op on fancy exp fix post op on tower (no paren) fix post op on tetration fix post op on fancy exp (paren and no paren differently)
|
As I was pretty much completely sure, I should fix that, I did. Now just max tower depth to figure out. It looks a lot better with, but we technically lose some info. (Maybe check for 1 in top exponent?) |
|
Yeah I think i'm too far away from math at the time to have a strong opinion tbh :D
This sounds a bit hacky, but I think that would suffice |
(if depth > 1)
While from semver-checks perspective, it really is just fix, it adds a whole class of inputs through the parser, which as not breaking should be minor.
|
Just adds one check to formatting towers and is by definition of tetration equal. And for that, we don't have a major version change in the lib now. (Kept minor version change as it is a new minor feature) |
|
Also added parsing of complex infinity (like a constant) as I just saw somebody try to use it again. |
tolik518
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have only one small suggestion, but I can also merge it as it is :)
|
Thank you, I'll merge that soon |
This adds parsing for Towers, Tetration and more intuitive numbers with exponent like
5.4 ⨉ 10^6.This is a breaking change for the library, as we add a new constant to control, how deep towers should be displayed for inputs.
Two questions: