Fix factorion sometimes giving wrong note with bad formatting #280
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
replace remove with too_long(_mult) in shorten all add proper paragraph formatting in that message add test case for edgecase number 3228
Owner
|
Perfect, thank you, I'll merge that one right away and look at #278 tomorrow |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I noticed that in edgecases like here factorion uses the wrong note.
That happens when it doesn't automatically shorten and has to shorten all, the wrong message was used and no paragraph spacing was added. l likely introduced the bug with locales.
Fixed and added test case.