Add configurable log levels for core engine#90
Merged
ehelms merged 1 commit intotheforeman:masterfrom Feb 3, 2026
Merged
Conversation
Add parameters to configure logging levels for insights.core.dr, insights_messaging, insights_kafka_service, and root loggers. Defaults preserve existing behavior (ERROR/INFO). Parameters are exposed in the main iop class for foreman-installer integration with core_engine_ prefix. Add tests to verify the config secret contains correct log level values for both default and custom configurations. Also test that log level parameters are properly passed through from the main iop class to iop::core_engine. Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
Member
Author
|
@ehelms here is the log level pr I was talking about |
ehelms
approved these changes
Feb 3, 2026
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add parameters to configure logging levels for insights.core.dr, insights_messaging, insights_kafka_service, and root loggers. Defaults preserve existing behavior (ERROR/INFO).
Parameters are exposed in the main iop class for foreman-installer integration with core_engine_ prefix.
Add tests to verify the config secret contains correct log level values for both default and custom configurations. Also test that log level parameters are properly passed through from the main iop class to iop::core_engine.
Output when set to debug:
New parameters added to iop::core_engine:
$log_level_insights_core_drERRORinsights.core.drlogger$log_level_insights_messagingINFOinsights_messaginglogger$log_level_insights_kafka_serviceINFOinsights_kafka_servicelogger$log_level_rootINFOValid values: DEBUG, INFO, WARNING, ERROR, CRITICAL
Example usage in Hiera: