fix: ensure we do not duplicate bubble text #1934
Conversation
palmer-cl
commented
Feb 4, 2026
palmer-cl
commented
- The document nodes are the source of truth for what appears in the editor, so they should define the comment text.
- Also keep the fallbacks
- added tests
caio-pizzol
left a comment
caio-pizzol
left a comment
There was a problem hiding this comment.
clean one @palmer-cl!
the only addition I would say here is that in this case, it also impacts rendering and interactions with the editor. we should definitely write interaction stories and upload a sample file for visual testing.
packages/super-editor/src/extensions/comment/comments-plugin.js
Outdated
Show resolved
Hide resolved
packages/super-editor/src/extensions/comment/comments-plugin.js
Outdated
Show resolved
Hide resolved
|
@caio-pizzol added VRTs and updated comments. |
| // safety net for identity dedupe | ||
| // work is done above |
There was a problem hiding this comment.
I think the previous comment ("Remove duplicates by comparing node identity") was clearer
caio-pizzol
left a comment
caio-pizzol
left a comment
There was a problem hiding this comment.
LGTM -
Missing behavior tests - I will add them later
caio-pizzol
deleted the
colep/sd-1739-bug-tracked-changes-replacements-duplicate-last-character
branch
|
@caio-pizzol dont the VRT screenshot tests have the behavior embedded in them? we have to perform the user actions before taking the screenshot? |
|
🎉 This PR is included in superdoc v1.13.0-next.2 The release is available on GitHub release |
4 participants
