Replace checkPaymentChannelBalance panic with error#11
Closed
bitwiseguy wants to merge 7 commits intonitro-integrationfrom
Closed
Replace checkPaymentChannelBalance panic with error#11bitwiseguy wants to merge 7 commits intonitro-integrationfrom
bitwiseguy wants to merge 7 commits intonitro-integrationfrom
Conversation
Basic Nitro Integration (Version 0)
Closed
geoknee
approved these changes
Jun 15, 2023
cmd/booster-http/server.go
Outdated
Comment on lines
208
to
213
| writeError(w, r, http.StatusInternalServerError, err.Error()) | ||
| return | ||
| } | ||
|
|
||
| if !hasPaid { | ||
| webError(w, fmt.Errorf("payment of %d required", expectedPaymentAmount.Uint64()), http.StatusPaymentRequired) |
There was a problem hiding this comment.
What's the difference between writeError and webError?
Author
There was a problem hiding this comment.
It looks like webError sets some additional headers related to CORS. I am changing this webError to writeError to conform to the rest of the error handling within this method.
geoknee
force-pushed
the
nitro-integration
branch
from
c735b03 to
559eaa9
Compare
|
@bitwiseguy the base branch was rebased, which is giving you the conflicts. Seeing as you are out and that's my fault, I'm happy to sort it out? |
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
resolves #9