fix: header must be a string, not array#953
Open
candrews wants to merge 1 commit intosemantic-release:masterfrom
Open
fix: header must be a string, not array#953candrews wants to merge 1 commit intosemantic-release:masterfrom
candrews wants to merge 1 commit intosemantic-release:masterfrom
Conversation
Contributor
@candrews The diff looks off. Please double check and ping me when ready for review. |
The header must be a string, not an array. Per the got documentation, `headers` is of type `object<string, string>`. See https://github.com/sindresorhus/got/blob/v14.6.6/documentation/2-options.md#headers Fixes the mis-typing problem introduced in semantic-release#919 which appears to cause GitLab releases to fail with incorrect `EINVALIDGLTOKEN Invalid GitLab token.` errors
candrews
force-pushed
the
header-string
branch
from
091b024 to
146c351
Compare
Author
It's fixed. All tests pass, lint reports success as well. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The header must be a string, not an array. Per the got documentation,
headersis of typeobject<string, string>. See https://github.com/sindresorhus/got/blob/v14.6.6/documentation/2-options.md#headersThis PR fixes the mis-typing problem introduced in #919 which appears to cause GitLab releases to fail with incorrect
EINVALIDGLTOKEN Invalid GitLab token.errors.@arvest-bjoneson @fgreinacher