Skip to content

Comments

feat: enable use of job token for gitlab api authentication#919

Merged
fgreinacher merged 16 commits intosemantic-release:masterfrom
arvest-bjoneson:feat/job-token
Feb 5, 2026
Merged

feat: enable use of job token for gitlab api authentication#919
fgreinacher merged 16 commits intosemantic-release:masterfrom
arvest-bjoneson:feat/job-token

Conversation

@arvest-bjoneson
Copy link
Contributor

@arvest-bjoneson arvest-bjoneson commented Oct 31, 2025 •
edited by hearts bot
Loading

This is an implementation of recommendations made in #901

@HagerError404
Copy link

HagerError404 commented Nov 25, 2025 •
edited by hearts bot
Loading

we are waiting for the merge :) works good

fgreinacher
fgreinacher requested changes Nov 26, 2025
View reviewed changes
Copy link
Contributor

@fgreinacher fgreinacher left a comment •
edited by hearts bot
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot @arvest-bjoneson! Please revert the formatting changes so that this is easier to review 🙇

@JonasSchubert
Copy link
Contributor

JonasSchubert commented Dec 12, 2025 •
edited by hearts bot
Loading

Thanks a lot @arvest-bjoneson! Please revert the formatting changes so that this is easier to review 🙇

Kind reminder to revert the formatting @arvest-bjoneson. Will help with the review. Thanks a lot for your contribution.

@arvest-bjoneson
Copy link
Contributor Author

arvest-bjoneson commented Dec 20, 2025 •
edited by hearts bot
Loading

My apologies for delay @fgreinacher @JonasSchubert - Formatting changes have been reverted!

Many thanks.

fgreinacher
fgreinacher reviewed Dec 21, 2025
View reviewed changes
fgreinacher
fgreinacher reviewed Dec 21, 2025
View reviewed changes
Copy link
Contributor

@fgreinacher fgreinacher left a comment •
edited by hearts bot
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the update @arvest-bjoneson, this looks great! Just one remaining question from my side.

fgreinacher
fgreinacher approved these changes Dec 22, 2025
View reviewed changes
Copy link
Contributor

@fgreinacher fgreinacher left a comment •
edited by hearts bot
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Again, thank you very much for the valuable contribution @arvest-bjoneson!

Happy holidays 🎄

@arvest-bjoneson
Copy link
Contributor Author

arvest-bjoneson commented Dec 22, 2025 •
edited by hearts bot
Loading

My pleasure! You too.

@fgreinacher
Copy link
Contributor

fgreinacher commented Dec 22, 2025 •
edited by hearts bot
Loading

Good to go once linter is happy 😉

@rzhornyk
Copy link

rzhornyk commented Jan 30, 2026 •
edited by hearts bot
Loading

Hi
Do we have updates on when this can be merged? We really need this functionality

@rzhornyk
Copy link

rzhornyk commented Feb 5, 2026 •
edited by hearts bot
Loading

Hi @arvest-bjoneson @fgreinacher
Sorry to bother you, but as I understand it, this pull request is in its final stage. Could we finalize it and proceed with the release? Is there anything that would prevent us from doing so?

fgreinacher
fgreinacher reviewed Feb 5, 2026
View reviewed changes
@fgreinacher
Copy link
Contributor

fgreinacher commented Feb 5, 2026 •
edited by hearts bot
Loading

@rzhornyk Thanks for the ping. I have fixed the pipeline issue. I'll go on merge this now. Thanks again for your contribution @arvest-bjoneson!

@fgreinacher fgreinacher merged commit fdd0953 into semantic-release:master Feb 5, 2026
14 checks passed
@github-actions
Copy link

github-actions bot commented Feb 5, 2026

🎉 This PR is included in version 13.3.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

This was referenced Feb 20, 2026
Open
Open
@candrews candrews mentioned this pull request Feb 23, 2026
Open
@candrews
Copy link

candrews commented Feb 23, 2026 •
edited by hearts bot
Loading

I believe this change introduced a problem with releases incorrectly failing with EINVALIDGLTOKEN Invalid GitLab token errors. I submitted a PR which I believe addresses the issue at #953

candrews added a commit to candrews/semantic-release-gitlab that referenced this pull request Feb 23, 2026
@candrews
fix: header must be a string, not array
146c351 
The header must be a string, not an array. Per the got documentation, `headers` is of type `object<string, string>`. See https://github.com/sindresorhus/got/blob/v14.6.6/documentation/2-options.md#headers

Fixes the mis-typing problem introduced in semantic-release#919 which appears to cause GitLab releases to fail with incorrect `EINVALIDGLTOKEN Invalid GitLab token.` errors
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@fgreinacher fgreinacher fgreinacher approved these changes

Assignees

No one assigned

Labels

released

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@arvest-bjoneson @HagerError404 @JonasSchubert @fgreinacher @rzhornyk @candrews