-
Notifications
You must be signed in to change notification settings - Fork 15
platforms.yml: fix RISC-V march #385
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
I think this is only used for the name of the CI job and nothing else. Now that the kernel defaults to FPU support on for RISC-V, we should probably change all of these to reflect that. Signed-off-by: Ivan-Velickovic <i.velickovic@unsw.edu.au>
|
It turns out there are lots of mentions of this still in various workflows (21 if I counted correctly). We need to update those simultaneously. Most of these are from invocations of the sel4test and sel4bench tests, which I could point to the factored out workflow in this repo now. I've trialled this in the seL4 repo and it has been working fairly well there. The other ones are deployment workflows in seL4, sel4test, sel4bench, various mentions in the ci-action repo, and the simulation workflows for PRs. The simulation workflow also has a factored out version here, but the repos still need to be updated. So overall, if everything is updated to point to the factored out workflows, it should be feasible to find all mentions. Once that is done, we could remove |
|
There are also still 3 mentions of |
|
Not really relevant for the setting here, but not clear to me if they need to be updated or not now that we have switched to a different default. We are still on |
Those are all referring to the ISA of an extra 'supervisor core' on those platforms from memory. seL4 does not run on those cores. |
|
When all of the centralisation PRs are merged, the following workflows are left to look at to remove |
I think this is only used for the name of the CI job and nothing else. Now that the kernel defaults to FPU support on for RISC-V, we should probably change all of these to reflect that.