Merged
Conversation
This allows new errors to have minimal diffs.
This is executing a TODO when the chain length exceeds 6 issuers deep.
Codecov Report
@@ Coverage Diff @@
## main #163 +/- ##
==========================================
+ Coverage 96.56% 96.62% +0.06%
==========================================
Files 15 15
Lines 4364 4480 +116
==========================================
+ Hits 4214 4329 +115
- Misses 150 151 +1
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
cpu
approved these changes
Sep 5, 2023
Member
cpu
left a comment
cpu
left a comment
There was a problem hiding this comment.
This looks great, thank you for tidying up some of the surrounding code. I peeked at the diff coverage dip and it's specific to the error ranking changes (which are much appreciated).
stanal
reviewed
Sep 5, 2023
Merged
This was referenced Sep 1, 2023
Closed
Merged
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is intended to be complementary to #160 and addresses briansmith/webpki#276 in the same manner as NSS libmozpkix.