backport rustls/webpki path complexity budget#277
Merged
briansmith merged 3 commits intobriansmith:mainfrom Sep 30, 2023
Merged
backport rustls/webpki path complexity budget#277briansmith merged 3 commits intobriansmith:mainfrom
briansmith merged 3 commits intobriansmith:mainfrom
Conversation
Codecov Report
@@ Coverage Diff @@
## main #277 +/- ##
==========================================
+ Coverage 50.62% 51.08% +0.45%
==========================================
Files 18 18
Lines 3751 3786 +35
==========================================
+ Hits 1899 1934 +35
Misses 1852 1852
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
This is intended to be complementary to the signature validation limit fix and addresses briansmith/webpki#276 in the same manner as NSS libmozpkix.
cpu
force-pushed
the
cpu-rustls-backport-path-complexity-fix
branch
from
6a47dc1 to
95b6b20
Compare
briansmith
approved these changes
Sep 30, 2023
Owner
|
Thank you. I pushed #279 for some follow-ups. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is intended to be complementary to the signature validation limit fix (#273) and addresses https://github.com/briansmith/webpki/issues/276 in the same manner as NSS libmozpkix. Originally implemented by @ctz in rustls/webpki#163.
Ive backported the change, adapting it to this repository's
mainbranch and folded in some later improvements that were made after rustls/webpki#163 (e.g. cleaning up imports, using a more readable numeric literal, fixing the unit test).