Merged
Conversation
Owner
Author
|
@cpu PTAL. Thanks! |
briansmith
force-pushed
the
b/cleanup-budget
branch
from
b7decd6 to
bef50e5
Compare
Codecov Report
@@ Coverage Diff @@
## main #279 +/- ##
==========================================
+ Coverage 51.81% 51.88% +0.07%
==========================================
Files 19 20 +1
Lines 4030 4036 +6
==========================================
+ Hits 2088 2094 +6
Misses 1942 1942
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
cpu
approved these changes
Sep 30, 2023
Contributor
cpu
left a comment
cpu
left a comment
There was a problem hiding this comment.
Thanks,
The adjustments look good to me, but I think the packaging tasks that failed in CI are true positives:
error[E0583]: file not found for module `budget`
--> src/lib.rs:44:1
|
44 | mod budget;
| ^^^^^^^^^^^
|
= help: to create the module `budget`, create file "src/budget.rs" or "src/budget/mod.rs"
I believe budget.rs has to be added to the Cargo.toml's include array.
Make it clear that nothing is reaching into the internals of `Budget`. In particular, clarify that the tests are not messing around with the defaults.
briansmith
force-pushed
the
b/cleanup-budget
branch
from
bef50e5 to
895e2cb
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
These are non-functional changes designed to clarify how the budget is encapsulated, along with some other tidying that I noticed was appropriate during the review of PR #277.
It is best to review this commit-by-commit.