-
-
Notifications
You must be signed in to change notification settings - Fork 14.3k
Rollup of 13 pull requests #151087
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rollup of 13 pull requests #151087
Conversation
When a trait parameter depends upon Sized, the error message only referred to the full trait itself and didn't mention Sized. This makes the failure to implement Sized explicit. It also notes when the Sized trait bound is explicit or implicit.
I chose to simply extend `dump.rs`, rather than create a new UI test.
Adapt `PathBuf::push` documentation for `Path::join` and add it to `join`'s docs Fix to comply with tidy Remove unnecessary whitespace
With the suggested value we were getting instead: ``` ERROR: Failed to parse '/tmp/rust/bootstrap.toml': unknown field `stage`, expected one of `build`, `description`, `host`, `target`, `build-dir`, `cargo`, `rustc`, `rustfmt`, `cargo-clippy`, `docs`, `compiler-docs`, `library-docs-private-items`, `docs-minification`, `submodules`, `gdb`, `lldb`, `nodejs`, `npm`, `yarn`, `python`, `windows-rc`, `reuse`, `locked-deps`, `vendor`, `full-bootstrap`, `bootstrap-cache-path`, `extended`, `tools`, `tool`, `verbose`, `sanitizers`, `profiler`, `cargo-native-static`, `low-priority`, `configure-args`, `local-rebuild`, `print-step-timings`, `print-step-rusage`, `check-stage`, `doc-stage`, `build-stage`, `test-stage`, `install-stage`, `dist-stage`, `bench-stage`, `patch-binaries-for-nix`, `metrics`, `android-ndk`, `optimized-compiler-builtins`, `jobs`, `compiletest-diff-tool`, `compiletest-allow-stage0`, `compiletest-use-stage0-libtest`, `tidy-extra-checks`, `ccache`, `exclude` for key `build` ```
The old toolchain is not working with recent rustc, as it does not defining `getauxval`
triagebot: add A-rustdoc-js autolabel Adds an autolabel rule for rustdoc JavaScript/TypeScript files so PRs touching rustdoc frontend assets and related tests are automatically labeled `A-rustdoc-js`. Fixes rust-lang#137983
Improve std::path::Path::join documentation Adapt `PathBuf::push` documentation for `Path::join` and add it to `join`'s docs rust-lang#146447
diagnostics: make implicit Sized bounds explicit in E0277 When a trait parameter depends upon Sized, the error message only referred to the full trait itself and didn't mention Sized. This makes the failure to implement Sized explicit. It also notes when the Sized trait bound is explicit or implicit. Fixes rust-lang#150576
Remove legacy homu `try` and `auto` branch mentions ~~To be merged once we get rid of homu.~~ I think that we can merge this now.
…nethercote Make `--print=check-cfg` output compatible `--check-cfg` arguments This PR changes significantly the output of the unstable `--print=check-cfg` option. Specifically it removes the ad-hoc resemblance with `--print=cfg` in order to output a simplified but still compatible `--check-cfg` arguments. The goal is to future proof the output of `--print=check-cfg` like `--check-cfg` is, and the best way to do that is to use it's syntax. This is particularly relevant for [RFC3905](rust-lang/rfcs#3905) which wants to introduce a new predicate: `version(...)`.
|
@bors r+ p=5 rollup=never |
|
@bors r+ p=5 rollup=never |
This comment has been minimized.
This comment has been minimized.
What is this?This is an experimental post-merge analysis report that shows differences in test outcomes between the merged PR and its parent PR.Comparing fcac501 (parent) -> 4931e09 (this PR) Test differencesShow 114 test diffsStage 1
Stage 2
Additionally, 98 doctest diffs were found. These are ignored, as they are noisy. Job group index
Test dashboardRun cargo run --manifest-path src/ci/citool/Cargo.toml -- \
test-dashboard 4931e09e3ac3182d2a00f38cccfdf68e8e385e1c --output-dir test-dashboardAnd then open Job duration changes
How to interpret the job duration changes?Job durations can vary a lot, based on the actual runner instance |
|
📌 Perf builds for each rolled up PR:
previous master: fcac501a73 In the case of a perf regression, run the following command for each PR you suspect might be the cause: |
|
Finished benchmarking commit (4931e09): comparison URL. Overall result: ❌ regressions - please read the text belowOur benchmarks found a performance regression caused by this PR. Next Steps:
@rustbot label: +perf-regression Instruction countOur most reliable metric. Used to determine the overall result above. However, even this metric can be noisy.
Max RSS (memory usage)Results (primary 1.8%, secondary 1.3%)A less reliable metric. May be of interest, but not used to determine the overall result above.
CyclesResults (primary 2.4%, secondary -3.1%)A less reliable metric. May be of interest, but not used to determine the overall result above.
Binary sizeResults (primary 0.0%, secondary 0.0%)A less reliable metric. May be of interest, but not used to determine the overall result above.
Bootstrap: 474.33s -> 474.176s (-0.03%) |
Successful merges:
tryandautobranch mentions #150771 (Remove legacy homutryandautobranch mentions)--print=check-cfgoutput compatible--check-cfgarguments #150840 (Make--print=check-cfgoutput compatible--check-cfgarguments)Type::ofsupport unsized types #151019 (MakeType::ofsupport unsized types)tests/rustdoc-gui/notable-trait.goml#151053 (Reduce flakyness fortests/rustdoc-gui/notable-trait.goml)r? @ghost
Create a similar rollup