Deduplicated float tests and unified in floats/mod.rs #148206

xonx4l · 2025-10-28T12:23:42Z

In this PR Float tests are deduplicated and are unified in floats/mod.rs, as discussed in #141726.

The moved float tests are:

-> test_powf
-> test_exp
-> test_exp2
-> test_ln
-> test_log_generic
-> test_log2
-> test_log10
-> test_asinh
-> test_acosh
-> test_atanh
-> test_gamma
-> test_ln_gamma

Closes: #141726

r? tgross35

rustbot · 2025-10-28T12:23:47Z

tgross35 is currently at their maximum review capacity.
They may take a while to respond.

library/std/tests/floats/lib.rs

xonx4l · 2025-11-11T12:19:21Z

Any update @bjorn3 ?

bjorn3 · 2025-11-11T12:22:56Z

CI is still failing.

xonx4l · 2025-11-11T12:27:03Z

CI is still failing.

ok let me fix .

rustbot · 2025-11-14T08:23:07Z

Some changes occurred in compiler/rustc_codegen_cranelift

cc @bjorn3

LorrensP-2158466 · 2025-11-17T23:39:14Z

library/coretests/tests/floats/mod.rs

+        let inf: Float = Float::INFINITY;
+        let neg_inf: Float = Float::NEG_INFINITY;
+        assert_biteq!((10.0 as Float).log(10.0), 1.0);
+        assert_approx_eq!((2.3 as Float).log(3.5), 0.664858, Float::LOG_APPROX);


This test here for f128 will fail because the precision is much higher, if you look at the original test, the expected value is much more precise than what you have written:

assert_approx_eq!(2.3f128.log(3.5), 0.66485771361478710036766645911922010272, TOL);

When testing higher precision floats, you need much more precise expected values or the tests will fail, as they do now. In Miri, this is even more strict.

If you look at the source of f16 constants, they use much more digits after the decimal point than needed:

pub const PI: f16 = 3.14159265358979323846264338327950288_f16;

So you should probably do that as well.

Okay it makes sense . Thanks

tgross35 · 2025-11-19T14:09:50Z

Thank you for the final cleanup here. Until CI is fixed,
@rustbot author

rustbot · 2025-11-19T14:09:55Z

Reminder, once the PR becomes ready for a review, use @rustbot ready.

xonx4l · 2025-11-19T18:27:09Z

Thank you for the final cleanup here. Until CI is fixed, @rustbot author

Will finish this as soon as possible . A bit busy these days.

xonx4l · 2026-01-09T10:29:33Z

@tgross35 I updated the tests as suggested but the aarch64 rustc_codegen_cranelift is still failing at the linker stage.

bjorn3 · 2026-01-09T10:52:32Z

Looks like cg_clif incorrectly implements these operations for f16: rust-lang/rustc_codegen_cranelift#1622 Feel free to drop a patch file in compiler/rustc_codegen_cranelift/patches with 0029-sysroot_tests- as prefix. The sysroot_tests tells cg_clif's build system to apply the patch when running standard library tests.

xonx4l · 2026-01-10T06:32:27Z

@rustbot ready

tgross35

A few requests for cleanup then I think this should be good. Could you please also squash the commits?

View changes since this review

tgross35 · 2026-01-10T21:43:23Z

library/coretests/tests/floats/mod.rs

-        let two: Float = 2.0;
-        let ten: Float = 10.0;
+        let two: Float = flt(2.0);
+        let ten: Float = flt(10.0);


Please drop any flt additions where they aren't replacing an as cast. It's only needed in cases where the type is ambiguous (e.g. 4.0.sqrt() could be any float's sqrt), not everywhere we have a literal.

(applies everywhere in the file)

tgross35 · 2026-01-10T21:47:39Z

library/coretests/tests/floats/mod.rs

+        assert!(flt(-0.0).asinh().is_sign_negative());
+        assert_approx_eq!(flt(2.0).asinh(), flt(1.443635475178810342493276740273105), Float::ASINH_APPROX);
+        assert_approx_eq!(flt(-2.0).asinh(), flt(-1.443635475178810342493276740273105), Float::ASINH_APPROX);
+
+        assert_approx_eq!(flt(-200.0).asinh(), flt(-5.991470797049389), Float::ASINH_APPROX);
+        if Float::MAX > flt(66000.0) {
+             assert_approx_eq!(flt(-67452098.07139316).asinh(), flt(-18.720075426274544393985484294000831757220), Float::ASINH_APPROX);
+        }


These test cases have some context comments in the original, please preserve them

rust/library/std/tests/floats/f64.rs

Lines 135 to 144 in f57eac1

// issue 63271

assert_approx_eq!(2.0f64.asinh(), 1.443635475178810342493276740273105f64);

assert_approx_eq!((-2.0f64).asinh(), -1.443635475178810342493276740273105f64);

// regression test for the catastrophic cancellation fixed in 72486

assert_approx_eq!((-67452098.07139316f64).asinh(), -18.72007542627454439398548429400083);

// test for low accuracy from issue 104548

assert_approx_eq!(60.0f64, 60.0f64.sinh().asinh());

// mul needed for approximate comparison to be meaningful

assert_approx_eq!(1.0f64, 1e-15f64.sinh().asinh() * 1e15f64);

tgross35 · 2026-01-10T21:48:16Z

library/coretests/tests/floats/mod.rs

+        assert_approx_eq!(flt(3.0).acosh(), flt(1.76274717403908605046521864995958461), Float::ACOSH_APPROX);
+
+        if Float::MAX > flt(66000.0) {
+            assert_approx_eq!(flt(60.0), flt(60.0).cosh().acosh(), Float::ACOSH_APPROX);


Ditto here

rust/library/std/tests/floats/f64.rs

Lines 161 to 162 in f57eac1

// test for low accuracy from issue 104548

assert_approx_eq!(60.0f64, 60.0f64.cosh().acosh());

tgross35 · 2026-01-10T21:56:24Z

library/coretests/tests/floats/mod.rs

-        assert_biteq!((0.0 as Float).min(0.0), 0.0);
-        assert_biteq!((-0.0 as Float).min(-0.0), -0.0);
-        assert_biteq!((9.0 as Float).min(9.0), 9.0);
-        assert_biteq!((-9.0 as Float).min(0.0), -9.0);
-        assert_biteq!((0.0 as Float).min(9.0), 0.0);
-        assert_biteq!((-0.0 as Float).min(9.0), -0.0);
-        assert_biteq!((-0.0 as Float).min(-9.0), -9.0);
-        assert_biteq!(Float::INFINITY.min(9.0), 9.0);
-        assert_biteq!((9.0 as Float).min(Float::INFINITY), 9.0);
-        assert_biteq!(Float::INFINITY.min(-9.0), -9.0);
-        assert_biteq!((-9.0 as Float).min(Float::INFINITY), -9.0);
-        assert_biteq!(Float::NEG_INFINITY.min(9.0), Float::NEG_INFINITY);
-        assert_biteq!((9.0 as Float).min(Float::NEG_INFINITY), Float::NEG_INFINITY);
-        assert_biteq!(Float::NEG_INFINITY.min(-9.0), Float::NEG_INFINITY);
-        assert_biteq!((-9.0 as Float).min(Float::NEG_INFINITY), Float::NEG_INFINITY);
-        assert_biteq!(Float::NAN.min(9.0), 9.0);
-        assert_biteq!(Float::NAN.min(-9.0), -9.0);
-        assert_biteq!((9.0 as Float).min(Float::NAN), 9.0);
-        assert_biteq!((-9.0 as Float).min(Float::NAN), -9.0);
+        assert_biteq!(flt(0.0).min(flt(0.0)), flt(0.0));
+        assert_biteq!(flt(-0.0).min(flt(-0.0)), flt(-0.0));
+        assert_biteq!(flt(9.0).min(flt(9.0)), flt(9.0));
+        assert_biteq!(flt(-9.0).min(flt(0.0)), flt(-9.0));
+        assert_biteq!(flt(0.0).min(flt(9.0)), flt(0.0));
+        assert_biteq!(flt(-0.0).min(flt(9.0)), flt(-0.0));
+        assert_biteq!(flt(-0.0).min(flt(-9.0)), flt(-9.0));
+        assert_biteq!(Float::INFINITY.min(flt(9.0)), flt(9.0));
+        assert_biteq!(flt(9.0).min(Float::INFINITY), flt(9.0));
+        assert_biteq!(Float::INFINITY.min(flt(-9.0)), flt(-9.0));
+        assert_biteq!(flt(-9.0).min(Float::INFINITY), flt(-9.0));
+        assert_biteq!(Float::NEG_INFINITY.min(flt(9.0)), Float::NEG_INFINITY);
+        assert_biteq!(flt(9.0).min(Float::NEG_INFINITY), Float::NEG_INFINITY);
+        assert_biteq!(Float::NEG_INFINITY.min(flt(-9.0)), Float::NEG_INFINITY);
+        assert_biteq!(flt(-9.0).min(Float::NEG_INFINITY), Float::NEG_INFINITY);
+        assert_biteq!(Float::NAN.min(flt(9.0)), flt(9.0));
+        assert_biteq!(Float::NAN.min(flt(-9.0)), flt(-9.0));
+        assert_biteq!(flt(9.0).min(Float::NAN), flt(9.0));
+        assert_biteq!(flt(-9.0).min(Float::NAN), flt(-9.0));


Doing the replacements like 0.0 as Float -> flt(0.0) are good 👍 but the rest wasn't ambiguous, please remove the unneeded flts.

tgross35 · 2026-01-10T22:01:32Z

library/coretests/tests/floats/mod.rs

+        assert_biteq!(flt(1.0).powf(flt(1.0)), flt(1.0));
+        assert_approx_eq!(flt(3.4).powf(flt(4.5)), flt(246.40818323761892815995637964326426756), Float::POWF_APPROX);
+        assert_approx_eq!(flt(2.7).powf(flt(-3.2)), flt(0.041652009108526178281070304373500889273), Float::POWF_APPROX);
+        assert_approx_eq!(flt(-3.1).powf(flt(2.0)), flt(9.6100000000000005506706202140776519387), Float::POWF_APPROX);
+        assert_approx_eq!(flt(5.9).powf(flt(-2.0)), flt(0.028727377190462507313100483690639638451), Float::POWF_APPROX);
+        assert_biteq!(flt(8.3).powf(flt(0.0)), flt(1.0));
+        assert!(nan.powf(flt(2.0)).is_nan());
+        assert_biteq!(inf.powf(flt(2.0)), inf);
+        assert_biteq!(neg_inf.powf(flt(3.0)), neg_inf);


Similarly, this can be simplified to assert_biteq!(flt(1.0).powf(1.0), 1.0);. Once it knows the type of the first 1.0, the rest of the functions will be the same type.

tgross35 · 2026-01-10T22:03:49Z

library/coretests/tests/floats/mod.rs

+}
+
+float_test! {
+    name: log_generic,


The original test was just called log

tgross35 · 2026-01-10T22:16:04Z

library/coretests/tests/floats/mod.rs

+    const FRAC_PI_2: Self;
+    const FRAC_PI_3: Self;
+    const FRAC_PI_4: Self;
+    const FRAC_PI_6: Self;
+    const FRAC_PI_8: Self;
+    const FRAC_1_PI: Self;
+    const FRAC_2_PI: Self;
+    const FRAC_2_SQRT_PI: Self;
+    const SQRT_2: Self;
+    const FRAC_1_SQRT_2: Self;
+    const E: Self;
+    const LOG2_E: Self;
+    const LOG10_E: Self;
+    const LN_2: Self;
+    const LN_10: Self;


Instead of these, update the eight test_* functions in https://github.com/xonx4l/rust/blob/fb26a5b86d57a19ef330866fac5c44ca2cf2a97a/library/coretests/tests/floats/mod.rs#L418-L505 to e.g.

#[test] $( $( #[$f16_meta] )+ )? fn test_f16() { #[allow(unused_imports)] use core::f16::consts; type $fty = f16; #[allow(unused)] const fn flt (x: $fty) -> $fty { x } $test }

(adding the use) then the tests can use e.g. consts::LOG2_E directly.

tgross35 · 2026-01-10T22:29:28Z

library/coretests/tests/floats/mod.rs

+    attrs: {
+        // FIXME(f16_f128): add math tests when available
+        const: #[cfg(false)],
+        f16: #[cfg(any(miri, target_has_reliable_f16))],


Suggested change

f16: #[cfg(any(miri, target_has_reliable_f16))],

f16: #[cfg(any(miri, target_has_reliable_f16_math))],

Fewer platforms enable reliable_x_math than for reliable_x, the _math option needs to be used whenever there are calls like .sqrt.

rustbot · 2026-01-13T20:48:09Z

Some changes occurred in GUI tests.

cc @GuillaumeGomez

rustbot · 2026-01-13T21:03:28Z

This PR was rebased onto a different main commit. Here's a range-diff highlighting what actually changed.

Rebasing is a normal part of keeping PRs up to date, so no action is needed—this note is just to help reviewers.

GuillaumeGomez · 2026-01-13T21:18:09Z

tests/rustdoc-gui/notable-trait.goml

    block {
        call-function: ("check-notable-tooltip-position", {"x": |x|, "i_x": |i_x|})
-        assert-count: ("//*[@class='tooltip popover']", 0)
+        assert-count: ("//*[@class='tooltip popover']", 1)


Please remove these changes.

rust-log-analyzer · 2026-01-13T22:06:56Z

The job x86_64-gnu-tools failed! Check out the build log: (web) (plain enhanced) (plain)

Click to see the possible cause of the failure (guessed by this bot)

............................................       (144/144)

======== tests/rustdoc-gui/notable-trait.goml ========

[ERROR] line 64
    at `tests/rustdoc-gui/notable-trait.goml` line 39: expected 1 elements, found 0: for command `assert-count: ("//*[@class='tooltip popover']", 1)`
    at <file:///checkout/obj/build/x86_64-unknown-linux-gnu/test/rustdoc-gui/doc/test_docs/struct.NotableStructWithLongName.html>
[ERROR] line 64
    at `tests/rustdoc-gui/notable-trait.goml` line 58: expected 1 elements, found 0: for command `assert-count: ("//*[@class='tooltip popover']", 1)`
    at <file:///checkout/obj/build/x86_64-unknown-linux-gnu/test/rustdoc-gui/doc/test_docs/struct.NotableStructWithLongName.html>
[ERROR] line 173
    at `tests/rustdoc-gui/notable-trait.goml` line 39: expected 1 elements, found 0: for command `assert-count: ("//*[@class='tooltip popover']", 1)`
    at <file:///checkout/obj/build/x86_64-unknown-linux-gnu/test/rustdoc-gui/doc/test_docs/struct.NotableStructWithLongName.html>
[ERROR] line 173
    at `tests/rustdoc-gui/notable-trait.goml` line 58: expected 1 elements, found 0: for command `assert-count: ("//*[@class='tooltip popover']", 1)`
    at <file:///checkout/obj/build/x86_64-unknown-linux-gnu/test/rustdoc-gui/doc/test_docs/struct.NotableStructWithLongName.html>
[ERROR] line 186: expected 1 elements, found 0: for command `assert-count: ("//*[@class='tooltip popover']", 1)`
    at <file:///checkout/obj/build/x86_64-unknown-linux-gnu/test/rustdoc-gui/doc/test_docs/struct.NotableStructWithLongName.html>
[ERROR] line 193: expected 1 elements, found 0: for command `assert-count: ("//*[@class='tooltip popover']", 1)`
    at <file:///checkout/obj/build/x86_64-unknown-linux-gnu/test/rustdoc-gui/doc/test_docs/struct.NotableStructWithLongName.html>
[ERROR] line 207: expected 1 elements, found 0: for command `assert-count: ("//*[@class='tooltip popover']", 1)`
    at <file:///checkout/obj/build/x86_64-unknown-linux-gnu/test/rustdoc-gui/doc/test_docs/struct.NotableStructWithLongName.html>
[ERROR] line 245: expected 1 elements, found 0: for command `assert-count: ("//*[@class='tooltip popover']", 1)`
    at <file:///checkout/obj/build/x86_64-unknown-linux-gnu/test/rustdoc-gui/doc/test_docs/struct.NotableStructWithLongName.html#method.create_an_iterator_from_read>
[ERROR] line 251: expected 1 elements, found 0: for command `assert-count: ("//*[@class='tooltip popover']", 1)`
    at <file:///checkout/obj/build/x86_64-unknown-linux-gnu/test/rustdoc-gui/doc/test_docs/struct.NotableStructWithLongName.html#method.create_an_iterator_from_read>
[ERROR] line 256: expected 1 elements, found 0: for command `assert-count: ("//*[@class='tooltip popover']", 1)`
    at <file:///checkout/obj/build/x86_64-unknown-linux-gnu/test/rustdoc-gui/doc/test_docs/struct.NotableStructWithLongName.html#method.create_an_iterator_from_read>

======== tests/rustdoc-gui/search-result-display.goml ========

[WARNING] line 39: Delta is 0 for "x", maybe try to use `compare-elements-position` instead?

rust-bors · 2026-01-14T06:54:59Z

☔ The latest upstream changes (presumably #151087) made this pull request unmergeable. Please resolve the merge conflicts.

rustbot assigned tgross35 Oct 28, 2025

rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-libs Relevant to the library team, which will review and decide on the PR/issue. labels Oct 28, 2025