Skip to content

Lock psych < 5 #41

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
hsbt merged 3 commits into from
Jan 29, 2026
+3 −2
Merged

Lock psych < 5 #41

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
f5aa1e4
Lock psych < 5
hsbt Jan 29, 2026
77140d4
Don't use bundler-cache
hsbt Jan 29, 2026
41cf04b
Don't use bundle exec
hsbt Jan 29, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions .github/workflows/build.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,6 +25,6 @@ jobs:
uses: ruby/setup-ruby@v1
with:
ruby-version: ${{ matrix.ruby }}
bundler-cache: true
- run: gem install rake-compiler
- name: Run test
run: bundle exec rake compile
run: rake compile
1 change: 1 addition & 0 deletions Gemfile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,4 +7,5 @@ group :development do
gem "rake"
gem "rake-compiler"
gem "rdoc"
gem "psych", "< 5.0" # psych 5.0+ requires Ruby 2.7+
Copy link

Copilot AI Jan 29, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The version constraint uses "< 5.0" which will exclude psych 5.0.0 but allow 4.x versions. However, consider using "~> 4.0" instead, which is more idiomatic in the Ruby ecosystem and makes it clearer that you're targeting the 4.x series. Alternatively, if you want to be more permissive and include any pre-5.0 version including potential 4.1, 4.2, etc., the current constraint is acceptable but could be written as "< 5" (without the .0) for brevity.

Suggested change
gem "psych", "< 5.0" # psych 5.0+ requires Ruby 2.7+
gem "psych", "~> 4.0" # psych 5.0+ requires Ruby 2.7+

Copilot uses AI. Check for mistakes.
end