Skip to content

Conversation

@hsbt
Copy link
Member

@hsbt hsbt commented Jan 29, 2026

No description provided.

Copilot AI review requested due to automatic review settings January 29, 2026 06:23
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR adds a version constraint on the psych gem to ensure compatibility with older Ruby versions (2.5 and 2.6) that are still supported by this project. Since psych 5.0+ requires Ruby 2.7+, this constraint prevents installation failures on Ruby 2.5-2.6.

Changes:

  • Added psych gem with version constraint < 5.0 to the development group in Gemfile

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

gem "rake"
gem "rake-compiler"
gem "rdoc"
gem "psych", "< 5.0" # psych 5.0+ requires Ruby 2.7+
Copy link

Copilot AI Jan 29, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The version constraint uses "< 5.0" which will exclude psych 5.0.0 but allow 4.x versions. However, consider using "~> 4.0" instead, which is more idiomatic in the Ruby ecosystem and makes it clearer that you're targeting the 4.x series. Alternatively, if you want to be more permissive and include any pre-5.0 version including potential 4.1, 4.2, etc., the current constraint is acceptable but could be written as "< 5" (without the .0) for brevity.

Suggested change
gem "psych", "< 5.0" # psych 5.0+ requires Ruby 2.7+
gem "psych", "~> 4.0" # psych 5.0+ requires Ruby 2.7+

Copilot uses AI. Check for mistakes.
@hsbt hsbt merged commit e92a720 into master Jan 29, 2026
40 checks passed
@hsbt hsbt deleted the fix-ci-issue branch January 29, 2026 07:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant