Improve CMake, add continuous integration #23
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Support Windows (MSVC and MinGW), Linux, and macOS * `libusb` installation can be specified explicitly by defining `LIBUSB_INCLUDE_DIRS` and `LIBUSB_LIBRARIES` CMake variables * Support the current structure of Windows `libusb` package, version 1.0.27 and newer * Select proper `libusb` MSVC libraries for various versions of Visual Studio * Remove duplicated and redundant command line options * Include `libusb.h` without `libusb-1.0` directory * `pkg-config` returns include string with this directory added * Windows packages don't have this directory at all * Normalize all CMake commands to lower case * Normalize indents by using 4 spaces * Install udev rules on Linux only
Build and test the following targets * Linux 64-bit using Clang and GCC * macOS 64-bit for ARM and Intel * Windows 64-bit via MinGW * Windows 32- and 64-bit via MSVC
* It produced unusable library because of name mangling, C code was compiled as C++ * It supported ARM only, Homebrew on Intel Macs uses different prefix
Contributor
Author
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Major update of CMake configuration
libusbinstallation can be specified explicitly by definingLIBUSB_INCLUDE_DIRSandLIBUSB_LIBRARIESCMake variableslibusbpackage, version 1.0.27 and newerlibusbMSVC libraries for various versions of Visual Studiolibusb.hwithoutlibusb-1.0directorypkg-configreturns include string with this directory addedBuild and test the following targets
Remove obsolete macOS build script, and update readme accordingly.