Skip to content

fix: allow self-signed ingress certificates to be trusted #281

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
ssthom wants to merge 2 commits into
base: master
Choose a base branch
from
Open

fix: allow self-signed ingress certificates to be trusted #281

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
d9086e5
fix: allow self-signed ingress certificates to be trusted
ssthom Apr 22, 2021
92ac921
Merge branch 'master' into selfSignedIngress
alewitt2 May 6, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions kubernetes/watch-keeper/resource.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,6 +34,8 @@ spec:
valueFrom:
fieldRef:
fieldPath: metadata.namespace
- name: NODE_EXTRA_CA_CERTS
value: /home/node/envs/watch-keeper-secret/cacerts.pem
Comment on lines +37 to +38
Copy link
Member

@alewitt2 alewitt2 May 6, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm fine with this except for the fact that there will be a warning when the file doesnt exist (which will probably be the majority of the time)

docs ref:

A message will be emitted (once) with process.emitWarning() if the file is missing or malformed, but any errors are otherwise ignored.

i think we can achieve the same result with an optional env.

Suggested change
- name: NODE_EXTRA_CA_CERTS
value: /home/node/envs/watch-keeper-secret/cacerts.pem
- name: NODE_EXTRA_CA_CERTS
valueFrom:
configMapKeyRef:
name: watch-keeper-config
key: NODE_EXTRA_CA_CERTS
optional: true

which means someone who wants to add extra certs will have to update both the watch-keeper-config with the ca certs path, as well as the watch-keeper-secret with the actual pem file.

Please make the change and test it. thanks.

- name: USER_AGENT_NAME
value: razee-io/watchkeeper
- name: USER_AGENT_VERSION
Expand Down