fix: allow self-signed ingress certificates to be trusted#281
Open
fix: allow self-signed ingress certificates to be trusted#281
Conversation
alewitt2
requested changes
May 6, 2021
Comment on lines
+37
to
+38
| - name: NODE_EXTRA_CA_CERTS | ||
| value: /home/node/envs/watch-keeper-secret/cacerts.pem |
Member
There was a problem hiding this comment.
I'm fine with this except for the fact that there will be a warning when the file doesnt exist (which will probably be the majority of the time)
A message will be emitted (once) with process.emitWarning() if the file is missing or malformed, but any errors are otherwise ignored.
i think we can achieve the same result with an optional env.
Suggested change
| - name: NODE_EXTRA_CA_CERTS | |
| value: /home/node/envs/watch-keeper-secret/cacerts.pem | |
| - name: NODE_EXTRA_CA_CERTS | |
| valueFrom: | |
| configMapKeyRef: | |
| name: watch-keeper-config | |
| key: NODE_EXTRA_CA_CERTS | |
| optional: true |
which means someone who wants to add extra certs will have to update both the watch-keeper-config with the ca certs path, as well as the watch-keeper-secret with the actual pem file.
Please make the change and test it. thanks.
|
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
By adding the NODE_EXTRA_CA_CERTS environment variable we can let razeedash trust self-signed certs which is needed if the ingress for your razeedash-api is self-signed. Otherwise you get the following in WatchKeeper:
To enable this you just add your certificate to the watch-keeper-secret secret with the key cacerts.pem. If you don't have that key in your secrets WatchKeeper still starts up fine, just no additional certs being accepted