Skip to content

fix: fix Android font rendering and share functionality#7199

Open
maxbbb wants to merge 1 commit into02-23-feature_carousel_for_pnl_card_selectionfrom
02-26-fix_android_font_and_share_fixes
Open

fix: fix Android font rendering and share functionality#7199
maxbbb wants to merge 1 commit into02-23-feature_carousel_for_pnl_card_selectionfrom
02-26-fix_android_font_and_share_fixes

Conversation

@maxbbb
Copy link
Contributor

@maxbbb maxbbb commented Feb 26, 2026

Fixes APP-####

What changed (plus any additional context for devs)

  • Upgraded react-native-share from 8.2.1 to 12.2.5 and switched from the native Share API to
    RNShare.open() for more reliable sharing behavior and share results on both platforms. Behavior is same on iOS. On Android this change was required to make the image export properly.
  • Fixed Android font rendering in PnL share graphics by using font patterns from the design
    system instead of raw fontFamily: 'SF Pro Rounded' strings.
  • Enhanced share analytics, moved the analytics event to fire after sharing completes, now tracking
    shared, success, and message fields from the share result.
  • Fixed ActivityIndicator color in share button to respect dark mode.
  • Added fileName to captured pnl images for clean.

Apologies for a few unrelated changes packaged together here, just a bit of final cleanup.

Screen recordings / screenshots

Screenshot_20260226_145822_Rainbow

Copy link
Contributor Author

maxbbb commented Feb 26, 2026

@socket-security
Copy link

Review the following changes in direct dependencies. Learn more about Socket for GitHub.

Diff Package Supply Chain
Security
Vulnerability Quality Maintenance License
Updatednpm/​react-native-share@​8.2.1 ⏵ 12.2.5100100100 +1295 +4100

View full report

@maxbbb maxbbb changed the title fix: Android font and share fixes fix: fix Android font rendering and improve share functionality Feb 26, 2026
@maxbbb maxbbb changed the title fix: fix Android font rendering and improve share functionality fix: fix Android font rendering and share functionality Feb 26, 2026
@maxbbb maxbbb marked this pull request as ready for review February 26, 2026 20:01
@github-actions
Copy link

Launch in simulator or device for 1820826

@github-actions
Copy link

🧪 Flashlight Performance Report (AWS Device Farm)

🔀 Commit: 1820826

📎 View Artifacts

Metric Current Δ vs Baseline
Time to Interactive (TTI) 5345 ms
Average FPS 57.01
Average RAM 374.9 MB

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant