Skip to content

feature: show trade details sheet after closing perps position#7142

Open
maxbbb wants to merge 1 commit into02-17-feature_add_pnl_graphic_to_trade_details_sheetfrom
02-18-feature_show_trade_details_sheet_after_closing_perps_position
Open

feature: show trade details sheet after closing perps position#7142
maxbbb wants to merge 1 commit into02-17-feature_add_pnl_graphic_to_trade_details_sheetfrom
02-18-feature_show_trade_details_sheet_after_closing_perps_position

Conversation

@maxbbb
Copy link
Contributor

@maxbbb maxbbb commented Feb 18, 2026

APP-3166

What changed (plus any additional context for devs)

  • After a successful perps close, we now wait for the resulting trade to be available and automatically
    open the trade details sheet.
  • closePosition now returns the Hyperliquid order status so we can extract the close orderId.
  • Added waitForTradeByOrderId utility to poll order fill status + refetch trades, then resolve the
    matching trade.
  • Added getTradeByOrderId in hlTradesStore and isOrderFilled in HyperliquidAccountClient to
    support this flow.

Screen recordings / screenshots

Simulator.Screen.Recording.-.iPhone.16e.-.2026-02-25.at.14.17.35.mov

What to test

Closing perps trades

Copy link
Contributor Author

maxbbb commented Feb 18, 2026

@maxbbb maxbbb force-pushed the 02-17-feature_add_pnl_graphic_to_trade_details_sheet branch from 9904704 to 69c98ac Compare February 20, 2026 16:24
@maxbbb maxbbb force-pushed the 02-18-feature_show_trade_details_sheet_after_closing_perps_position branch from bcb31ed to 4c822f7 Compare February 20, 2026 16:24
@maxbbb maxbbb force-pushed the 02-17-feature_add_pnl_graphic_to_trade_details_sheet branch from 69c98ac to 0c0f4a3 Compare February 20, 2026 16:36
@maxbbb maxbbb force-pushed the 02-18-feature_show_trade_details_sheet_after_closing_perps_position branch from 4c822f7 to 6f5e88c Compare February 20, 2026 16:36
@maxbbb maxbbb force-pushed the 02-17-feature_add_pnl_graphic_to_trade_details_sheet branch from 0c0f4a3 to f03b428 Compare February 23, 2026 18:26
@maxbbb maxbbb force-pushed the 02-18-feature_show_trade_details_sheet_after_closing_perps_position branch 2 times, most recently from 19d5595 to f5f57a4 Compare February 23, 2026 21:22
@maxbbb maxbbb force-pushed the 02-17-feature_add_pnl_graphic_to_trade_details_sheet branch from f03b428 to 797d25d Compare February 23, 2026 21:22
@maxbbb maxbbb force-pushed the 02-18-feature_show_trade_details_sheet_after_closing_perps_position branch 2 times, most recently from a82f985 to c2e78d0 Compare February 23, 2026 23:03
@maxbbb maxbbb force-pushed the 02-17-feature_add_pnl_graphic_to_trade_details_sheet branch 2 times, most recently from 929e61c to 1c7dd46 Compare February 23, 2026 23:06
@maxbbb maxbbb force-pushed the 02-18-feature_show_trade_details_sheet_after_closing_perps_position branch 3 times, most recently from 88d233a to cf456cc Compare February 25, 2026 17:43
@maxbbb maxbbb force-pushed the 02-17-feature_add_pnl_graphic_to_trade_details_sheet branch from 6ca5ef2 to 555949c Compare February 25, 2026 17:43
@maxbbb maxbbb force-pushed the 02-18-feature_show_trade_details_sheet_after_closing_perps_position branch from cf456cc to 6f98f35 Compare February 25, 2026 17:59
@maxbbb maxbbb force-pushed the 02-17-feature_add_pnl_graphic_to_trade_details_sheet branch from 555949c to c80dc5a Compare February 25, 2026 17:59
@maxbbb maxbbb force-pushed the 02-18-feature_show_trade_details_sheet_after_closing_perps_position branch from 6f98f35 to f2f74bd Compare February 25, 2026 18:07
@maxbbb maxbbb force-pushed the 02-17-feature_add_pnl_graphic_to_trade_details_sheet branch from c80dc5a to 5685b98 Compare February 25, 2026 18:07
@maxbbb maxbbb force-pushed the 02-18-feature_show_trade_details_sheet_after_closing_perps_position branch from f2f74bd to e241ce3 Compare February 25, 2026 18:44
@maxbbb maxbbb force-pushed the 02-18-feature_show_trade_details_sheet_after_closing_perps_position branch from e241ce3 to e7bb1b9 Compare February 25, 2026 18:51
@maxbbb maxbbb marked this pull request as ready for review February 25, 2026 19:21
@github-actions
Copy link

Launch in simulator or device for 4c76937

@github-actions
Copy link

🧪 Flashlight Performance Report (AWS Device Farm)

🔀 Commit: 4c76937

📎 View Artifacts

Metric Current Δ vs Baseline
Time to Interactive (TTI) 5488 ms
Average FPS 56.98
Average RAM 399.8 MB

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant