feature: show trade details sheet after closing perps position#7142
Open
maxbbb wants to merge 1 commit into02-17-feature_add_pnl_graphic_to_trade_details_sheetfrom
Conversation
This was referenced Feb 18, 2026
Contributor
Author
|
Warning This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
This stack of pull requests is managed by Graphite. Learn more about stacking. |
9904704 to
69c98ac
Compare
bcb31ed to
4c822f7
Compare
69c98ac to
0c0f4a3
Compare
4c822f7 to
6f5e88c
Compare
0c0f4a3 to
f03b428
Compare
19d5595 to
f5f57a4
Compare
f03b428 to
797d25d
Compare
a82f985 to
c2e78d0
Compare
929e61c to
1c7dd46
Compare
88d233a to
cf456cc
Compare
6ca5ef2 to
555949c
Compare
cf456cc to
6f98f35
Compare
555949c to
c80dc5a
Compare
6f98f35 to
f2f74bd
Compare
c80dc5a to
5685b98
Compare
f2f74bd to
e241ce3
Compare
e241ce3 to
e7bb1b9
Compare
|
🧪 Flashlight Performance Report (AWS Device Farm) 🔀 Commit: 4c76937
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

APP-3166
What changed (plus any additional context for devs)
open the trade details sheet.
closePositionnow returns the Hyperliquid order status so we can extract the closeorderId.waitForTradeByOrderIdutility to poll order fill status + refetch trades, then resolve thematching trade.
getTradeByOrderIdinhlTradesStoreandisOrderFilledinHyperliquidAccountClienttosupport this flow.
Screen recordings / screenshots
Simulator.Screen.Recording.-.iPhone.16e.-.2026-02-25.at.14.17.35.mov
What to test
Closing perps trades