Add "terms of service" checkbox #35
Conversation
Add this checkbox both to SignupForm and UserProfileForm. Checkbox is shown in UserProfileForm only if user hasn't already accepted terms of service. User cannot save changes to settings unless he accepts terms of service.
pylab/accounts/forms.py
Outdated
|
pylab.lt/terms/ page is not added yet. I'll create it based on google terms of service. |
Also rewrite one sentence describing environment for development preparation.
|
According to https://tosdr.org/ Google TOS is rated as Class C. |
|
Nice page, combination of wikipedia and duckduckgo terms seems fair. |
|
I guess duckduckgo is more about searching the web and wikipedia is more similar to pylab - people create content. So maybe instead of writing our own TOS, we could add link to Wikipedia TOS and add tosdr.org badge? I guess to write a good TOS you have to be a lawyer. |
|
Also try to not forget to add references to original source of information to pull request description (same applies to commit messages and tasks). In this case, original source of information is #20. When commits, pull requests and tasks have references between them it is easier to find out what is going on. And github implements referencing different types of content very well. |
There was a problem hiding this comment.
I think it is better to refer to Wikipedia TOS and additionally tosdr.org badge could be added.
Also, intellectual property can't be given to anyone and no content should belong to Python workshops, TOS should tell, that you agree that all created content will be released to public under a CC licence. And for code, terms off LICENSE file in each repository applies.
Anyway this is tricky part.
|
Since you want to enforce terms of service, I think a middleware should be created in order to check if registered users accepted terms and conditions. If TOS where not accepted, middleware should always redirect user to TOS form. |
There was a problem hiding this comment.
Consider using [Terms of serivce](http://pylab.lt/terms/){:target=_blank} to force link to TOS open in new tab instead of replacing current page, possibly loosing filled form values.
|
Just wanted to let you know, that I can't approve this pull request, while link to terms and conditions does not work. At least create empty page with some TODO note in it. |
Connects to #20.