Voting poll #49
Merged
Voting poll #49
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
Please do not forget to specify what task this pull request implements. |
Contributor
|
And it looks like this pull request is mixed with #35. |
Contributor
Author
|
Very strange, migrations fail with |
Sorry guys, that was my error, forgot to add dependency on website migrations, since website migration have to be run first, before core, to transfer Project model from website to core.
Contributor
|
Master does not have this fix. |
Not finished yet, should create tests and improve usability with JavaScript. Also max allowed total points should be assigned to user, then tracked and validated in form is_valid method.
And fill this field when vote form is saved.
Also fix pylint and html warnings.
Also add about page test.
|
Strange TravisCI error: failed to download https://github.com/twbs/bootstrap/releases/download/v3.3.1/bootstrap-3.3.1-dist.zip |
15 total voting points is now hardcoded, but VotingPoll should store this value.
Contributor
|
The same issue with bootstrap downloading in #48 |
Version updated from 3.3.1 to 3.3.5, because Travis-CI started to raise 503 service unavailable error when trying to download 3.3.5 Bootstrap version.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issues: #44 and #45