add download links for remediated files when present #240
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ajkiessl
reviewed
Feb 2, 2026
Comment on lines
+58
to
+63
| if document.remediated_final_submissions.any? | ||
| links = remediated_final_submissions_links(document) | ||
| links << final_submission_links(document) if this_user.email == document[:author_email_ssi] | ||
| else | ||
| links = final_submission_links(document) | ||
| end |
Contributor
There was a problem hiding this comment.
It is possible for someone to have multiple PDFs for a single submission, right? If so, how do we plan to handle remediation for the other PDFs if the unremediated file links are hidden when there are .any? remediated files? We might want to adjust the code on the workflow side to trigger remediation for all final submission files associated with the submission that received the remediation trigger.
Author
There was a problem hiding this comment.
Ahh my mistake, I thought that was what was happening on the workflow side. I'll make that change over there
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.