Auto remediation notification on download link #239
Conversation
…iles. Refactor some things, particularly fake_solr_document. Moves variabels in initialize to private methods
…fic. This is necessary for links to be correct when multiple files. Reversed modal inclusion logic, this was wrong
ajkiessl
changed the title
jlandiseigsti
left a comment
jlandiseigsti
left a comment
There was a problem hiding this comment.
Code all looks good...just some text changes
|
|
||
| def db_legacy_id | ||
| @db_legacy_id ||= Faker::Number.unique.within(range: 1..1000) | ||
| end |
There was a problem hiding this comment.
Appreciate you cleaning this up.
| <p>We're generating an accessible version of this file to meet ADA Title II requirements. This process may take up to one hour. Please return later to access the accessible copy once it's ready.</p> | ||
|
|
||
| <h6><strong>What's happening:</strong></h6> | ||
| <p>An accessible PDF is generated using Adobe with AI used to generate alternative text (alt text) for images in the PDF.</p> |
There was a problem hiding this comment.
Maybe "an accessible PDF is being generated"?
|
|
||
| <h6><strong>Quality check:</strong></h6> | ||
| <p>The Libraries' Adaptive Technology and Services team will review and correct the accessible version manually, but that review may occur after the file becomes available.</p> | ||
|
|
There was a problem hiding this comment.
So I actually don't think this is true for files on ETDA Explore. My understanding is that neither the Libraries nor the grad school have the capacity to review and correct ETDA files manually, and so this heading and paragraph should be removed until such time as there actually is a manual review.
There was a problem hiding this comment.
I removed the quality check part, and also the email. I also added a line to let the user know they can still download the current version by clicking "OK". Hopefully that prevents any confusion about whether they can still download the file.
closes psu-libraries/etda_workflow#976
Adds this popup when download links are clicked to start remediation (on show and index pages):
I updated the
rdocgem to get rid of a bunch of deprecation warnings. Also, I refactored thefake_solr_documentto move the variables out of the initialize method, and into their own memoized private methods. This just made it easier to work with.We do not have a webdriver integrated with Explore, so I cannot run full JS included integration tests to confirm the javascript works. However, the unit tests I added cover pretty much everything happening in the
render_download_linksmethod in the customBlacklightDisplayHelpermodule. This and bootstrap do 99% of the work. I figured it wasn't worth adding webdrivers for this change.We might want to consider adding a light webdriver like Cuprite at some point.