fix(typegen): prevent duplication of generator-owned methods (readValidator/writeValidator) for Edm.Boolean fields during regeneration #119
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Collaborator
Author
This stack of pull requests is managed by Graphite. Learn more about stacking. |
@proofkit/better-auth
@proofkit/cli
create-proofkit
@proofkit/fmdapi
@proofkit/fmodata
@proofkit/typegen
@proofkit/webviewer
commit: |
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
Bugbot Autofix is OFF. To automatically fix reported issues with Cloud Agents, enable Autofix in the Cursor dashboard.
Collaborator
Author
eluce2
changed the base branch from
02-10-fix_fmodata_preserve_useentityids_through_navigate_
to
graphite-base/119
…idator/writeValidator) for Edm.Boolean fields during regeneration
… function Refactored the regex execution in the extractMethodNamesFromChain function to improve performance by eliminating unnecessary variable declarations. Additionally, updated test cases to ensure proper formatting of generated output in fmodata-preserve-customizations test.
…id matching nested methods Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
eluce2
force-pushed
the
02-10-fix_typegen_prevent_duplication_of_generator-owned_methods_readvalidator_writevalidator_for_edm.boolean_fields_during_regeneration
branch
from
8f42e92 to
8203a33
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note
Medium Risk
Touches the codegen customization-preservation parser, which can subtly change regenerated output for existing schemas (though covered by new e2e tests).
Overview
Fixes
generateODataTypesregeneration so generator-owned chain methods (e.g.readValidator/writeValidatoronEdm.Booleanfield builders) are treated as standard and are no longer duplicated when merging preserved customizations.Adds a small chain parser (
extractMethodNamesFromChain) and extends customization extraction to accept additional standard methods, plus new e2e tests ensuring validators aren’t duplicated and that user-added outer.transform()calls are still preserved. Includes a patch changeset for@proofkit/typegen.Written by Cursor Bugbot for commit 8203a33. This will update automatically on new commits. Configure here.