fix(fmodata): preserve useEntityIds through navigate() #118
+56
−7
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
navigate() lost per-table useEntityIds after Database.from() mutation fix. Now passes resolved useEntityIds to new EntitySet and resolves navigation path names through resolveTableId for entity ID support. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Collaborator
Author
This stack of pull requests is managed by Graphite. Learn more about stacking. |
@proofkit/better-auth
@proofkit/cli
create-proofkit
@proofkit/fmdapi
@proofkit/fmodata
@proofkit/typegen
@proofkit/webviewer
commit: |
Collaborator
Author
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
navigate() lost per-table useEntityIds after Database.from() mutation
fix. Now passes resolved useEntityIds to new EntitySet and resolves
navigation path names through resolveTableId for entity ID support.
Co-Authored-By: Claude Opus 4.6 noreply@anthropic.com
Note
Low Risk
Small, localized URL/path construction changes with added test coverage; main risk is subtle regressions in navigation path formatting for entity-ID vs name-based routing.
Overview
Fixes
navigate()so entity-ID mode is preserved across navigation chains.EntitySet.navigate()now forwardsuseEntityIdsinto the newly-createdEntitySetand resolves both the source table name and relation name viaresolveTableId;RecordBuilder.navigate()similarly resolves the relation identifier viaresolveTableId. Tests add coverage ensuring generated navigation paths useFMTID:*identifiers (and not table names) for both EntitySet- and record-based navigation when per-tableuseEntityIdsis enabled.Written by Cursor Bugbot for commit b5dfb43. This will update automatically on new commits. Configure here.