Skip to content

Conversation

@JoTurk
Copy link
Member

@JoTurk JoTurk commented Dec 20, 2025

Description

Add ice renomination so we can advertise it from webrtc now that we added renomination
https://datatracker.ietf.org/doc/html/draft-thatcher-ice-renomination-01#section-3

@codecov
Copy link

codecov bot commented Dec 20, 2025

Codecov Report

❌ Patch coverage is 83.33333% with 2 lines in your changes missing coverage. Please review.
✅ Project coverage is 97.43%. Comparing base (7944863) to head (898beb3).
⚠️ Report is 1 commits behind head on master.

Files with missing lines Patch % Lines
jsep.go 83.33% 1 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #237      +/-   ##
==========================================
- Coverage   97.55%   97.43%   -0.13%     
==========================================
  Files          12       12              
  Lines        1393     1404      +11     
==========================================
+ Hits         1359     1368       +9     
- Misses         18       19       +1     
- Partials       16       17       +1     
Flag Coverage Δ
go 97.43% <83.33%> (-0.13%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@JoTurk JoTurk requested a review from philipch07 December 20, 2025 07:20
Copy link
Contributor

@philipch07 philipch07 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome to finally have it! :)

@JoTurk JoTurk merged commit 898beb3 into master Dec 20, 2025
19 checks passed
@JoTurk JoTurk deleted the ice-renomination-option branch December 20, 2025 15:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

2 participants