Skip to content

Conversation

@JoTurk
Copy link
Member

@JoTurk JoTurk commented Dec 20, 2025

Description

Advertise renomination ice-option when it's enabled. https://datatracker.ietf.org/doc/html/draft-thatcher-ice-renomination-01#section-3

continues pion/sdp#237 and #3306

@JoTurk JoTurk changed the title Advertise ICE renomination option Advertise ICE renomination option in SDP Dec 20, 2025
@JoTurk JoTurk added this to the V4.2.0 milestone Dec 20, 2025
@codecov
Copy link

codecov bot commented Dec 20, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 85.04%. Comparing base (0f4f3a0) to head (d8828d6).
⚠️ Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #3317      +/-   ##
==========================================
+ Coverage   84.95%   85.04%   +0.09%     
==========================================
  Files          80       80              
  Lines        9478     9482       +4     
==========================================
+ Hits         8052     8064      +12     
+ Misses       1004      997       -7     
+ Partials      422      421       -1     
Flag Coverage Δ
go 85.04% <100.00%> (+0.09%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@JoTurk JoTurk force-pushed the ice-renomination-option branch from 55e3b07 to c780e7d Compare December 20, 2025 17:34
@JoTurk JoTurk force-pushed the ice-renomination-option branch from c780e7d to d8828d6 Compare December 20, 2025 17:35
Copy link
Contributor

@philipch07 philipch07 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🥳

@JoTurk JoTurk merged commit d8828d6 into master Dec 20, 2025
30 of 31 checks passed
@JoTurk JoTurk deleted the ice-renomination-option branch December 20, 2025 18:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

3 participants