Skip to content

Deprecate SubscriberHelper and SubscriberUtil and update docs to use a CONST instead #802

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
DanielBadura merged 1 commit into from
Jan 6, 2026
Merged

Deprecate SubscriberHelper and SubscriberUtil and update docs to use a CONST instead #802

DanielBadura merged 1 commit into from
Jan 6, 2026

Conversation

@DanielBadura
Copy link
Member

@DanielBadura DanielBadura commented Jan 6, 2026 •
edited
Loading

closes #743

@DanielBadura DanielBadura added this to the 3.15.0 milestone Jan 6, 2026
@DanielBadura DanielBadura self-assigned this Jan 6, 2026
@DanielBadura DanielBadura added the documentation Improvements or additions to documentation label Jan 6, 2026
@DanielBadura DanielBadura changed the title Depreacte SubscriberHelper and SubscriberUtil and update docs to use a CONST instead Deprecate SubscriberHelper and SubscriberUtil and update docs to use a CONST instead Jan 6, 2026
@DanielBadura DanielBadura force-pushed the deprecate-subscriber-util-and-helper branch from f30cecf to 33a5134 Compare January 6, 2026 12:22
@DanielBadura DanielBadura linked an issue Jan 6, 2026 that may be closed by this pull request
Make SubscriberUtil obsolete and remove it #743
Closed
@github-actions
Copy link

github-actions bot commented Jan 6, 2026 •
edited
Loading

Hello 👋

here is the most recent benchmark result: 

SubscriptionEngineBench
=======================

+---------------------------+-----------------+-----------------+-----------+-----------------+------------+-------------+
|                           | time (kde mode)                               | memory                                     |
+---------------------------+-----------------+-----------------+-----------+-----------------+------------+-------------+
| subject                   | Tag: <current>  | Tag: base       | time-diff | Tag: <current>  | Tag: base  | memory-diff |
+---------------------------+-----------------+-----------------+-----------+-----------------+------------+-------------+
| benchHandle10000Events () | 3.205s (±0.00%) | 3.220s (±0.00%) | -0.48%    | 47.489mb        | 48.004mb   | -1.07%      |
+---------------------------+-----------------+-----------------+-----------+-----------------+------------+-------------+

SimpleSetupBench
================

+----------------------------------------+--------------------+--------------------+-----------+-----------------+------------+-------------+
|                                        | time (kde mode)                                     | memory                                     |
+----------------------------------------+--------------------+--------------------+-----------+-----------------+------------+-------------+
| subject                                | Tag: <current>     | Tag: base          | time-diff | Tag: <current>  | Tag: base  | memory-diff |
+----------------------------------------+--------------------+--------------------+-----------+-----------------+------------+-------------+
| benchLoad1Event ()                     | 1.027ms (±0.00%)   | 1.019ms (±0.00%)   | +0.74%    | 34.976mb        | 34.976mb   | 0.00%       |
| benchLoad10000Events ()                | 61.377ms (±0.00%)  | 60.592ms (±0.00%)  | +1.30%    | 34.976mb        | 34.976mb   | 0.00%       |
| benchSave1Event ()                     | 1.246ms (±0.00%)   | 1.382ms (±0.00%)   | -9.88%    | 34.976mb        | 34.976mb   | 0.00%       |
| benchSave10000Events ()                | 219.318ms (±0.00%) | 222.423ms (±0.00%) | -1.40%    | 34.976mb        | 34.976mb   | 0.00%       |
| benchSave10000Aggregates ()            | 8.386s (±0.00%)    | 8.556s (±0.00%)    | -1.99%    | 34.976mb        | 34.976mb   | 0.00%       |
| benchSave10000AggregatesTransaction () | 4.907s (±0.00%)    | 4.921s (±0.00%)    | -0.29%    | 34.976mb        | 34.976mb   | 0.00%       |
+----------------------------------------+--------------------+--------------------+-----------+-----------------+------------+-------------+

CommandToQueryBench
===================

+----------------+------------------+------------------+-----------+-----------------+------------+-------------+
|                | time (kde mode)                                 | memory                                     |
+----------------+------------------+------------------+-----------+-----------------+------------+-------------+
| subject        | Tag: <current>   | Tag: base        | time-diff | Tag: <current>  | Tag: base  | memory-diff |
+----------------+------------------+------------------+-----------+-----------------+------------+-------------+
| benchCreate () | 2.467ms (±0.00%) | 2.564ms (±0.00%) | -3.78%    | 4.945mb         | 4.945mb    | 0.00%       |
| benchUpdate () | 3.868ms (±0.00%) | 3.731ms (±0.00%) | +3.66%    | 4.945mb         | 4.945mb    | 0.00%       |
| benchBoth ()   | 6.851ms (±0.00%) | 7.239ms (±0.00%) | -5.37%    | 5.065mb         | 5.594mb    | -9.45%      |
+----------------+------------------+------------------+-----------+-----------------+------------+-------------+

SnapshotsBench
==============

+----------------------------------------+-------------------+-------------------+-----------+-----------------+------------+-------------+
|                                        | time (kde mode)                                   | memory                                     |
+----------------------------------------+-------------------+-------------------+-----------+-----------------+------------+-------------+
| subject                                | Tag: <current>    | Tag: base         | time-diff | Tag: <current>  | Tag: base  | memory-diff |
+----------------------------------------+-------------------+-------------------+-----------+-----------------+------------+-------------+
| benchLoad10000EventsMissingSnapshot () | 60.427ms (±0.00%) | 60.497ms (±0.00%) | -0.12%    | 34.981mb        | 34.981mb   | 0.00%       |
| benchLoad10000Events ()                | 1.252ms (±0.00%)  | 1.244ms (±0.00%)  | +0.62%    | 34.981mb        | 34.981mb   | 0.00%       |
+----------------------------------------+-------------------+-------------------+-----------+-----------------+------------+-------------+

SplitStreamBench
================

+-------------------------+--------------------+--------------------+-----------+-----------------+------------+-------------+
|                         | time (kde mode)                                     | memory                                     |
+-------------------------+--------------------+--------------------+-----------+-----------------+------------+-------------+
| subject                 | Tag: <current>     | Tag: base          | time-diff | Tag: <current>  | Tag: base  | memory-diff |
+-------------------------+--------------------+--------------------+-----------+-----------------+------------+-------------+
| benchLoad10000Events () | 5.511ms (±0.00%)   | 5.439ms (±0.00%)   | +1.34%    | 35.581mb        | 35.581mb   | 0.00%       |
| benchSave10000Events () | 342.616ms (±0.00%) | 342.677ms (±0.00%) | -0.02%    | 35.583mb        | 35.583mb   | 0.00%       |
+-------------------------+--------------------+--------------------+-----------+-----------------+------------+-------------+

SimpleSetupStreamStoreBench
===========================

+----------------------------------------+--------------------+--------------------+-----------+-----------------+------------+-------------+
|                                        | time (kde mode)                                     | memory                                     |
+----------------------------------------+--------------------+--------------------+-----------+-----------------+------------+-------------+
| subject                                | Tag: <current>     | Tag: base          | time-diff | Tag: <current>  | Tag: base  | memory-diff |
+----------------------------------------+--------------------+--------------------+-----------+-----------------+------------+-------------+
| benchLoad1Event ()                     | 1.153ms (±0.00%)   | 1.149ms (±0.00%)   | +0.29%    | 35.138mb        | 35.138mb   | 0.00%       |
| benchLoad10000Events ()                | 64.963ms (±0.00%)  | 64.961ms (±0.00%)  | +0.00%    | 35.138mb        | 35.138mb   | 0.00%       |
| benchSave1Event ()                     | 1.220ms (±0.00%)   | 1.613ms (±0.00%)   | -24.38%   | 35.138mb        | 35.138mb   | 0.00%       |
| benchSave10000Events ()                | 289.735ms (±0.00%) | 284.985ms (±0.00%) | +1.67%    | 35.138mb        | 35.138mb   | 0.00%       |
| benchSave10000Aggregates ()            | 8.513s (±0.00%)    | 8.652s (±0.00%)    | -1.61%    | 35.138mb        | 35.138mb   | 0.00%       |
| benchSave10000AggregatesTransaction () | 5.082s (±0.00%)    | 5.089s (±0.00%)    | -0.13%    | 35.138mb        | 35.138mb   | 0.00%       |
+----------------------------------------+--------------------+--------------------+-----------+-----------------+------------+-------------+

PersonalDataBench
=================

+----------------------------------------+--------------------+--------------------+-----------+-----------------+------------+-------------+
|                                        | time (kde mode)                                     | memory                                     |
+----------------------------------------+--------------------+--------------------+-----------+-----------------+------------+-------------+
| subject                                | Tag: <current>     | Tag: base          | time-diff | Tag: <current>  | Tag: base  | memory-diff |
+----------------------------------------+--------------------+--------------------+-----------+-----------------+------------+-------------+
| benchLoad1Event ()                     | 1.075ms (±0.00%)   | 1.085ms (±0.00%)   | -0.92%    | 35.582mb        | 35.582mb   | 0.00%       |
| benchLoad10000Events ()                | 91.918ms (±0.00%)  | 94.105ms (±0.00%)  | -2.32%    | 35.582mb        | 35.582mb   | 0.00%       |
| benchSave1Event ()                     | 1.974ms (±0.00%)   | 2.108ms (±0.00%)   | -6.39%    | 35.582mb        | 35.582mb   | 0.00%       |
| benchSave10000Events ()                | 254.917ms (±0.00%) | 251.184ms (±0.00%) | +1.49%    | 35.654mb        | 35.654mb   | 0.00%       |
| benchSave10000Aggregates ()            | 12.655s (±0.00%)   | 12.664s (±0.00%)   | -0.07%    | 35.582mb        | 35.582mb   | 0.00%       |
| benchSave10000AggregatesTransaction () | 9.134s (±0.00%)    | 9.128s (±0.00%)    | +0.06%    | 36.041mb        | 36.041mb   | 0.00%       |
+----------------------------------------+--------------------+--------------------+-----------+-----------------+------------+-------------+

SubscriptionEngineBatchBench
============================

+---------------------------+-------------------+-------------------+-----------+-----------------+------------+-------------+
|                           | time (kde mode)                                   | memory                                     |
+---------------------------+-------------------+-------------------+-----------+-----------------+------------+-------------+
| subject                   | Tag: <current>    | Tag: base         | time-diff | Tag: <current>  | Tag: base  | memory-diff |
+---------------------------+-------------------+-------------------+-----------+-----------------+------------+-------------+
| benchHandle10000Events () | 81.187ms (±0.00%) | 79.150ms (±0.00%) | +2.57%    | 35.476mb        | 35.476mb   | 0.00%       |
+---------------------------+-------------------+-------------------+-----------+-----------------+------------+-------------+

This comment gets update everytime a new commit comes in!

@DanielBadura DanielBadura merged commit a18515f into 3.15.x Jan 6, 2026
40 of 41 checks passed
@DanielBadura DanielBadura deleted the deprecate-subscriber-util-and-helper branch January 6, 2026 12:44
@github-actions github-actions bot mentioned this pull request Jan 8, 2026
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@DavidBadura DavidBadura DavidBadura approved these changes

Assignees

@DanielBadura DanielBadura

Labels

documentation Improvements or additions to documentation

Projects

None yet

Milestone

3.15.0

Development

Successfully merging this pull request may close these issues.

Make SubscriberUtil obsolete and remove it

3 participants

@DanielBadura @DavidBadura