Added setDomesticHotWaterSchedule command for Heating Devices#368
Open
jeremias-jordan wants to merge 4 commits intoopenviess:masterfrom
Open
Added setDomesticHotWaterSchedule command for Heating Devices#368jeremias-jordan wants to merge 4 commits intoopenviess:masterfrom
jeremias-jordan wants to merge 4 commits intoopenviess:masterfrom
Conversation
Author
|
It's been a while and i'd really like to see this command available. Any news on this PR? |
Member
|
Thanks for the PR, could you add types to the function and parameters. Also tests would be nice. |
Contributor
|
Here's what CFenner is asking for: Type annotations: @handleAPICommandErrors
def setDomesticHotWaterSchedule(self, schedule: dict):
return self.service.setProperty("heating.dhw.schedule", "setSchedule",
{'newSchedule': schedule})Test (e.g., in def test_getDomesticHotWaterScheduleModes(self):
expected_modes = ['on'] # check your test data for actual modes
self.assertSetEqual(
set(self.device.getDomesticHotWaterScheduleModes()), expected_modes)You might also want to add |
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added setDomesticHotWaterSchedule command for Heating Devices. Tested with V200KW1.