Add heating schedule setter for circuits#701
Conversation
93e6ce0 to
c23842b
Compare
|
See also PR #368 which adds |
PyViCare/PyViCareHeatingDevice.py
Outdated
There was a problem hiding this comment.
Sure! The schedule structure is a nested dict (day keys → list of time slot dicts), so the most accurate type would be quite verbose. Would dict be sufficient, or do you have something more specific in mind? Note that the existing setDomesticHotWaterCirculationSchedule has the same untyped schedule parameter — happy to type that one too while we're at it.
There was a problem hiding this comment.
Then lets go with a dict, the we at least have something.
|
@CFenner Friendly ping — any thoughts on the typing approach for the schedule parameter? Happy to go with |
5684a19 to
3adbd0b
Compare
|
Added |
Adds ability to set heating circuit schedules via the API, complementing the existing getHeatingSchedule() method. Fixes openviess#539
3adbd0b to
0e75f2d
Compare
Summary
Adds methods to set heating circuit schedules:
setHeatingSchedule(schedule)- set the heating schedule for a circuitgetHeatingScheduleModes()- get available schedule modes (e.g., reduced, normal, fixed)This complements the existing
getHeatingSchedule()method and follows the same pattern assetDomesticHotWaterCirculationSchedule().Fixes #539
Test plan
getHeatingScheduleModes()using Vitocal300G test data