-
Notifications
You must be signed in to change notification settings - Fork 39
Add sops-nix secrets in the tests #270
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
JulienMalka
wants to merge
4
commits into
users
Choose a base branch
from
secrets
base: users
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
a93da6e to
a9d482e
Compare
Add stubs for system.activationScripts options used by sops-nix: - generate-age-key - setupSecrets - setupSecretsForUsers These stubs allow importing sops-nix module without requiring the full NixOS activation scripts infrastructure.
sops-nix uses hostKeys to auto-detect SSH keys for age decryption. This stub allows the module to evaluate; users on non-NixOS systems should set sops.age.sshKeyPaths explicitly.
Verify that secrets can be decrypted using an ed25519 SSH host key converted to age format via sops.age.sshKeyPaths, which is useful for machines that already have SSH host keys and don't want to manage separate age key files.
jfroche
added a commit
that referenced
this pull request
Jan 22, 2026
Users consuming system-manager as a flake input only need the package, lib, and modules - not the test infrastructure. By moving VM tests to a subflake, the main flake stays minimal with nixpkgs as its only input. This separation enables CI to run fast package checks independently from slow VM tests, and provides proper flake.lock version pinning for test dependencies like nix-vm-test (replacing the inline fetchTarball). Future test dependencies (e.g., sops-nix for compatibility testing in #270) can be added to testFlake without touching the main flake.
jfroche
added a commit
that referenced
this pull request
Jan 22, 2026
Users consuming system-manager as a flake input only need the package, lib, and modules - not the test infrastructure. By moving VM tests to a subflake, the main flake stays minimal with nixpkgs as its only input. This separation enables CI to run fast package checks independently from slow VM tests, and provides proper flake.lock version pinning for test dependencies like nix-vm-test (replacing the inline fetchTarball). Future test dependencies (e.g., sops-nix for compatibility testing in #270) can be added to testFlake without touching the main flake.
jfroche
added a commit
that referenced
this pull request
Jan 22, 2026
Users consuming system-manager as a flake input only need the package, lib, and modules - not the test infrastructure. By moving VM tests to a subflake, the main flake stays minimal with nixpkgs as its only input. This separation enables CI to run fast package checks independently from slow VM tests, and provides proper flake.lock version pinning for test dependencies like nix-vm-test (replacing the inline fetchTarball). Future test dependencies (e.g., sops-nix for compatibility testing in #270) can be added to testFlake without touching the main flake.
jfroche
added a commit
that referenced
this pull request
Jan 22, 2026
Users consuming system-manager as a flake input only need the package, lib, and modules - not the test infrastructure. By moving VM tests to a subflake, the main flake stays minimal with nixpkgs as its only input. This separation enables CI to run fast package checks independently from slow VM tests, and provides proper flake.lock version pinning for test dependencies like nix-vm-test (replacing the inline fetchTarball). Future test dependencies (e.g., sops-nix for compatibility testing in #270) can be added to testFlake without touching the main flake.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We support sops-nix secrets!
This depends on a number of other changes including #266, so this is not ready.
I am bringing
sops-nixas a flake input for the sake of testing, I don't know how we feel about that.I had to add the dependency to
sysinit-reactivation.targetto thesops-nixsystemd unit, I think we should contribute that upstream, otherwise users will trip on it.