refactor: isolate VM tests into separate testFlake #329
+141
−41
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jfroche
force-pushed
the
subflake
branch
2 times, most recently
from
4f8a39c to
865678b
Compare
Users consuming system-manager as a flake input only need the package, lib, and modules - not the test infrastructure. By moving VM tests to a subflake, the main flake stays minimal with nixpkgs as its only input. This separation enables CI to run fast package checks independently from slow VM tests, and provides proper flake.lock version pinning for test dependencies like nix-vm-test (replacing the inline fetchTarball). Future test dependencies (e.g., sops-nix for compatibility testing in #270) can be added to testFlake without touching the main flake.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Users consuming system-manager as a flake input only need the package, lib, and modules - not the test infrastructure. By moving VM tests to a subflake, the main flake stays minimal with nixpkgs as its only input.
This separation enables CI to run fast package checks independently from slow VM tests, and provides proper flake.lock version pinning for test dependencies like nix-vm-test (replacing the inline fetchTarball).
Future test dependencies (e.g., sops-nix for compatibility testing in #270) can be added to testFlake without touching the main flake.