Skip to content

Accessing UI with unauthenticated and/or expired token lead to a crash #25

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
ncode wants to merge 1 commit into from
Closed

Accessing UI with unauthenticated and/or expired token lead to a crash #25

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 6 additions & 2 deletions cmd/nacp/nacp.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -88,7 +88,7 @@ func resolveTokenAccessor(transport http.RoundTripper, nomadAddress *url.URL, to
defer resp.Body.Close()

if resp.StatusCode != http.StatusOK {
return nil, fmt.Errorf("failed to resolve token: %s", resp.Status)
return nil, fmt.Errorf("unexpected status code: %s", resp.Status)
}

var aclToken api.ACLToken
Expand Down Expand Up @@ -142,12 +142,16 @@ func NewProxyHandler(nomadAddress *url.URL, jobHandler *admissionctrl.JobHandler
tokenInfo, err := resolveTokenAccessor(transport, nomadAddress, token)
if err != nil {
appLogger.Error("Resolving token failed", "error", err)
writeError(w, err)
}
if tokenInfo != nil {
reqCtx.AccessorID = tokenInfo.AccessorID
reqCtx.TokenInfo = tokenInfo
}
}

// Even tho we have resolveToken set to true, the initial connection will be issued without a token for the auth
// so it's better to validate whether it's populated or not
if reqCtx.TokenInfo != nil {
appLogger.Info("Request received", "path", r.URL.Path, "method", r.Method, "clientIP", reqCtx.ClientIP, "accessorID", reqCtx.AccessorID)
} else {
appLogger.Info("Request received", "path", r.URL.Path, "method", r.Method, "clientIP", reqCtx.ClientIP)
Expand Down
Loading