Accessing UI with unauthenticated and/or expired token lead to a crash #25
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ncode
changed the title
ncode
changed the title
Contributor
Author
|
@mxab I will leave as a draft until I find all the corner cases :) |
ncode
changed the title
Contributor
Author
|
We've been running with this patch since last week and found no more issues. So I'm happy with it now. |
Owner
|
Hi @ncode really sorry for picking this up now, I was in the middle of the otel stuff and just had the time to review and reproduce it now. I'm currently trying to setup a test for it now an wondering if we should either "ignore" the resolving error like you do it or actually check if is one of the actionable calls i.e. registry, plan or validate and only do then the resolving? |
Owner
|
I hope you don't might that I'm closing this PR as I think the way where we handle only relevant requests is more suitable #49 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Accessing Nomad via nacp with resolve token enabled will lead to a crash since we pass and empty pointer to applogger, so now we will only try to log if a token is render regardless if enabled or not.
The second part is to change to only log when a token resolution fail, so avoid use popups like the attached image shows