-
Notifications
You must be signed in to change notification settings - Fork 94
feat: add document actions to data browsing - edit, copy, clone, delete VSCODE-729 #1239
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
lerouxb
wants to merge
12
commits into
main
Choose a base branch
from
document-card-crud-operations
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
12 commits
Select commit
Hold shift + click to select a range
2a0a599
add document actions to data browsing - edit, copy, clone, delete
lerouxb 625d636
clone fixes
lerouxb 7488f01
most buttons should only show up when there's an id
lerouxb dc6aa5a
tests for action bar
lerouxb 7c1f27c
add tests for new vscode api functions
lerouxb 67e6933
tests for new methods in data browsing controller
lerouxb 3d5557f
add test for documentDeleted message
lerouxb f1970f0
remove unused
lerouxb b9155e6
better stub
lerouxb 7dd4185
Update src/views/data-browsing-app/monaco-viewer.tsx
lerouxb b53c151
Update src/views/dataBrowsingController.ts
lerouxb 282931d
Update src/test/suite/views/data-browsing-app/messageHandler.test.tsx
lerouxb File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -57,7 +57,7 @@ export default class DocumentTreeItem | |
|
|
||
| const documentLabel = document._id | ||
| ? JSON.stringify(document._id) | ||
| : `Document ${documentIndexInTree + 1}`; | ||
| : `"Document ${documentIndexInTree + 1}"`; | ||
|
Contributor
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. As a drive-by I removed the double "" around the text that's usually JSON.stringified and therefore already has "" around it, but then in this case I had to add it back.
lerouxb marked this conversation as resolved.
Show resolved
Hide resolved
|
||
|
|
||
| this.dataService = dataService; | ||
| this.document = document; | ||
|
|
@@ -112,9 +112,11 @@ export default class DocumentTreeItem | |
|
|
||
| if (shouldConfirmDeleteDocument === true) { | ||
| const confirmationResult = await vscode.window.showInformationMessage( | ||
| `Are you sure you wish to drop this document${this.tooltip ? ` "${this.tooltip}"` : ''}? This confirmation can be disabled in the extension settings.`, | ||
| `Are you sure you wish to drop this document${this.tooltip ? ` ${this.tooltip}` : ''}?`, | ||
| { | ||
| modal: true, | ||
| detail: | ||
| 'This confirmation can be disabled in the extension settings.', | ||
| }, | ||
| 'Yes', | ||
| ); | ||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As a drive-by I updated all these to put the extra text as detail so it is not just a narrow sea of text. I went looking for a way to make these modals wider because an object id typically does not fit in the width by 1 character. And this is all I found. Still makes these look a little bit better, though.