chore: add VSIX install tests VSCODE-703 #1235
Conversation
| run: pnpm run check-vsix-size | ||
| shell: bash | ||
|
|
||
| - name: Run VSIX Install Test |
There was a problem hiding this comment.
should we run this on forks? I was thinking this has some potential security risks because of this installation being a rather odd thing.
There was a problem hiding this comment.
Not sure of this thread is new or old but I guess after Slack discussion, you'd wanna add the install tests for forked PRs? Also fine if you wish to do that in a follow up PR.
There was a problem hiding this comment.
Perhaps one thing to note - this action is now only used in draft-release workflow.
There was a problem hiding this comment.
Pull request overview
This PR adds VSIX installation testing to ensure the extension package can be successfully installed and uninstalled across different operating systems (macOS, Windows, Linux).
Changes:
- Added a new bash script to test VSIX installation and uninstallation
- Integrated the test into the package.json scripts and GitHub Actions workflow
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| scripts/test-vsix-install.sh | New script that finds, installs, verifies, and uninstalls the VSIX extension on different operating systems |
| package.json | Added new test-install script command to run the VSIX installation test |
| .github/workflows/actions/test-and-build/action.yaml | Added workflow step to execute VSIX installation tests in CI/CD pipeline |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
gagik
force-pushed
the
gagik/install-vsix
branch
from
2c08a43 to
89af78a
Compare
himanshusinghs
left a comment
himanshusinghs
left a comment
There was a problem hiding this comment.
This is looking good. I flagged small things to consider.
| run: pnpm run check-vsix-size | ||
| shell: bash | ||
|
|
||
| - name: Run VSIX Install Test |
There was a problem hiding this comment.
Not sure of this thread is new or old but I guess after Slack discussion, you'd wanna add the install tests for forked PRs? Also fine if you wish to do that in a follow up PR.
| run: pnpm run check-vsix-size | ||
| shell: bash | ||
|
|
||
| - name: Run VSIX Install Test |
There was a problem hiding this comment.
Perhaps one thing to note - this action is now only used in draft-release workflow.
| finalize: | ||
| name: Sign and Upload | ||
| needs: [test, test-install] | ||
|
|
||
| runs-on: ubuntu-latest | ||
|
|
||
| steps: | ||
| - name: Checkout | ||
| uses: actions/checkout@v4 | ||
| with: | ||
| fetch-depth: 0 | ||
|
|
||
| - name: Setup Node environment | ||
| uses: ./.github/workflows/actions/setup-node-environment | ||
|
|
||
| - name: Download .vsix | ||
| uses: actions/download-artifact@v4 | ||
| with: | ||
| name: vsix | ||
|
|
||
| - name: Sign .vsix |
There was a problem hiding this comment.
Small nit: One thing I just now realised that the "Sign .vsix" is relevant only at the time of releasing (in draft-release workflow) so if you wish to further simplify, very likely we could skip the VSIX signing and uploading here.
|
@himanshusinghs added draft + fork adjustments. Snyk will be separated in the next PR and I might turn each job into actions as well as another follow-up |
|
Semgrep found 1 Using variable interpolation 🛟 Help? Slack #semgrep-help or go/semgrep-help. Resolution Options:
|
2 participants
This includes some of the refactoring from #1133 and adds the VSIX test script from #1188
There's a few CI follows up I want to do: