-
Notifications
You must be signed in to change notification settings - Fork 45
impl swanlab monitor #450
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
+161
−0
Merged
impl swanlab monitor #450
Changes from all commits
Commits
Show all changes
6 commits
Select commit
Hold shift + click to select a range
3f9f0e3
impl swanlab monitor
binary-husky 78c7aa3
Update trinity/utils/monitor.py
binary-husky 0ed5969
Update trinity/utils/monitor.py
binary-husky 841eb42
Add unit tests for SwanlabMonitor functionality
binary-husky 103c403
Refactor SwanlabMonitor test setup for improved environment handling
binary-husky 6dba669
Refactor monitor module for improved structure and readability
binary-husky File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Some comments aren't visible on the classic Files Changed page.
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,37 @@ | ||
| import os | ||
| import unittest | ||
|
|
||
|
|
||
| class TestSwanlabMonitor(unittest.TestCase): | ||
| @classmethod | ||
| def setUpClass(cls): | ||
| os.environ["SWANLAB_API_KEY"] = "xxxxxxxxxxxxxxxxxxxxx" | ||
|
|
||
| @classmethod | ||
| def tearDownClass(cls): | ||
| # Restore original environment variables | ||
| for k, v in cls._original_env.items(): | ||
| if v is None: | ||
| os.environ.pop(k, None) | ||
| else: | ||
| os.environ[k] = v | ||
|
|
||
| @unittest.skip("Requires swanlab package and network access") | ||
| def test_swanlab_monitor_smoke(self): | ||
| from trinity.utils.monitor import SwanlabMonitor | ||
|
|
||
| # Try creating the monitor; if swanlab isn't installed, __init__ will assert | ||
| mon = SwanlabMonitor( | ||
| project="trinity-smoke", | ||
| group="cradle", | ||
| name="swanlab-env", | ||
| role="tester", | ||
| ) | ||
|
|
||
| # Log a minimal metric to verify basic flow | ||
| mon.log({"smoke/metric": 1.0}, step=1) | ||
| mon.close() | ||
|
|
||
|
|
||
| if __name__ == "__main__": | ||
| unittest.main() |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.