impl swanlab monitor #450

binary-husky · 2025-12-24T18:51:43Z

Description

Support swanlab as logger.

gemini-code-assist · 2025-12-24T18:51:56Z

Summary of Changes

Hello @binary-husky, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request integrates the SwanLab experiment tracking platform by introducing a new SwanlabMonitor class. This addition allows users to effectively log, visualize, and manage their machine learning experiments with SwanLab, offering detailed configuration options for experiment setup, data logging, and run lifecycle management. The implementation focuses on flexible initialization and robust data handling, including support for complex tabular data structures.

Highlights

SwanLab Integration: A new SwanlabMonitor class has been introduced, enabling seamless integration with the SwanLab experiment tracking platform for monitoring machine learning experiments.
Configurable Experiment Tracking: The SwanlabMonitor supports extensive configuration through config.monitor.monitor_args, allowing users to specify project details, workspace, experiment name, description, tags, logging mode, and resume policies.
API Key Management: SwanLab login is managed by checking the SWANLAB_API_KEY environment variable, ensuring secure and flexible authentication.
Enhanced Data Logging: The monitor provides dedicated methods for logging both scalar metrics (log) and tabular data (log_table), with log_table capable of converting pandas DataFrames into SwanLab ECharts Tables or CSV strings.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	`/gemini review`	Performs a code review for the current pull request in its current state.
Pull Request Summary	`/gemini summary`	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	`/gemini help`	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

gemini-code-assist

Code Review

This pull request introduces SwanlabMonitor for experiment tracking. The implementation is a solid foundation. I've provided feedback focusing on improving robustness, consistency, and maintainability. Key points include a critical fix for API key handling to support all documented authentication methods, improving exception handling to prevent silent failures, and aligning the new monitor with existing conventions in the project for default arguments and documentation. These changes will help make the new monitor more reliable and user-friendly.

trinity/utils/monitor.py

Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>

pan-x-c · 2025-12-25T02:30:57Z

trinity/utils/monitor.py

+    This monitor integrates with SwanLab (https://swanlab.cn/) to track experiments.
+
+    Supported monitor_args in config.monitor.monitor_args:
+                - api_key (Optional[str]): API key for swanlab.login(). If omitted, will read from env


fix the indent

pan-x-c · 2025-12-25T02:34:03Z

/unittest-module-utils

github-actions · 2025-12-25T02:36:53Z

Summary

Tests 📝	Passed ✅	Failed ❌	Skipped ⏭️	Other ❓	Flaky 🍂	Duration ⏱️
28	27	1	0	0	0	1m

Failed Tests

Failed Tests ❌	Fail Message
❌ tests/utils/swanlab_test.py::TestSwanlabMonitor::test_swanlab_monitor_smoke	The test failed in the call phase due to an assertion error

Tests

Test Name	Status	Duration
tests/utils/eval_utils_test.py::TestComputeScore::test_both_boxed_and_equivalent	✅	53ms
tests/utils/eval_utils_test.py::TestComputeScore::test_both_boxed_and_not_equivalent	✅	1ms
tests/utils/eval_utils_test.py::TestComputeScore::test_empty_ground_truth	✅	2ms
tests/utils/eval_utils_test.py::TestComputeScore::test_empty_solution_string	✅	1ms
tests/utils/eval_utils_test.py::TestComputeScore::test_multiple_boxed_answers_in_solution	✅	2ms
tests/utils/eval_utils_test.py::TestComputeScore::test_solution_boxed_truth_raw_and_equivalent	✅	1ms
tests/utils/eval_utils_test.py::TestComputeScore::test_solution_boxed_truth_raw_and_not_equivalent	✅	1ms
tests/utils/eval_utils_test.py::TestComputeScore::test_solution_not_boxed	✅	1ms
tests/utils/eval_utils_test.py::TestComputeScore::test_solution_raw_and_ground_truth_boxed_equivalent	✅	1ms
tests/utils/eval_utils_test.py::TestMathEvalUtils::test_extract_answer	✅	4ms
tests/utils/eval_utils_test.py::TestMathEvalUtils::test_verify_math_answer	✅	144ms
tests/utils/eval_utils_test.py::TestEvalUtils::test_is_equiv	✅	5ms
tests/utils/log_test.py::LogTest::test_actor_log	✅	7.2s
tests/utils/log_test.py::LogTest::test_group_by_node	✅	1.8s
tests/utils/log_test.py::LogTest::test_no_actor_log	✅	709ms
tests/utils/plugin_test.py::TestPluginLoader::test_load_plugins_local_0__workspace_tests_utils_plugins	✅	99ms
tests/utils/plugin_test.py::TestPluginLoader::test_load_plugins_local_1_tests_utils_plugins	✅	96ms
tests/utils/plugin_test.py::TestPluginLoader::test_load_plugins_remote_0__workspace_tests_utils_plugins	✅	12.2s
tests/utils/plugin_test.py::TestPluginLoader::test_load_plugins_remote_1_tests_utils_plugins	✅	10.6s
tests/utils/plugin_test.py::TestPluginLoader::test_passing_custom_class_0__workspace_tests_utils_plugins	✅	6.0s
tests/utils/plugin_test.py::TestPluginLoader::test_passing_custom_class_1_tests_utils_plugins	✅	5.7s
tests/utils/registry_test.py::TestRegistryWithRay::test_dynamic_import	✅	5.7s
tests/utils/registry_test.py::TestRegistry::test_algorithm_registry_mapping	✅	14ms
tests/utils/registry_test.py::TestRegistry::test_buffer_module_registry_mapping	✅	493ms
tests/utils/registry_test.py::TestRegistry::test_common_module_registry_mapping	✅	47ms
tests/utils/registry_test.py::TestRegistry::test_register_module	✅	1ms
tests/utils/registry_test.py::TestRegistry::test_utils_module_registry_mapping	✅	1ms
tests/utils/swanlab_test.py::TestSwanlabMonitor::test_swanlab_monitor_smoke	❌	1ms

Github Test Reporter by CTRF 💚

pan-x-c · 2025-12-25T03:05:58Z

/unittest-module-utils

github-actions · 2025-12-25T03:08:54Z

Summary

Tests 📝	Passed ✅	Failed ❌	Skipped ⏭️	Other ❓	Flaky 🍂	Duration ⏱️
28	27	1	0	0	0	1m 4s

Failed Tests

Failed Tests ❌	Fail Message
❌ tests/utils/swanlab_test.py::TestSwanlabMonitor::test_swanlab_monitor_smoke	The test failed in the call phase

Tests

Test Name	Status	Duration
tests/utils/eval_utils_test.py::TestComputeScore::test_both_boxed_and_equivalent	✅	210ms
tests/utils/eval_utils_test.py::TestComputeScore::test_both_boxed_and_not_equivalent	✅	1ms
tests/utils/eval_utils_test.py::TestComputeScore::test_empty_ground_truth	✅	2ms
tests/utils/eval_utils_test.py::TestComputeScore::test_empty_solution_string	✅	1ms
tests/utils/eval_utils_test.py::TestComputeScore::test_multiple_boxed_answers_in_solution	✅	2ms
tests/utils/eval_utils_test.py::TestComputeScore::test_solution_boxed_truth_raw_and_equivalent	✅	1ms
tests/utils/eval_utils_test.py::TestComputeScore::test_solution_boxed_truth_raw_and_not_equivalent	✅	1ms
tests/utils/eval_utils_test.py::TestComputeScore::test_solution_not_boxed	✅	1ms
tests/utils/eval_utils_test.py::TestComputeScore::test_solution_raw_and_ground_truth_boxed_equivalent	✅	1ms
tests/utils/eval_utils_test.py::TestMathEvalUtils::test_extract_answer	✅	4ms
tests/utils/eval_utils_test.py::TestMathEvalUtils::test_verify_math_answer	✅	144ms
tests/utils/eval_utils_test.py::TestEvalUtils::test_is_equiv	✅	5ms
tests/utils/log_test.py::LogTest::test_actor_log	✅	6.7s
tests/utils/log_test.py::LogTest::test_group_by_node	✅	1.8s
tests/utils/log_test.py::LogTest::test_no_actor_log	✅	708ms
tests/utils/plugin_test.py::TestPluginLoader::test_load_plugins_local_0__workspace_tests_utils_plugins	✅	98ms
tests/utils/plugin_test.py::TestPluginLoader::test_load_plugins_local_1_tests_utils_plugins	✅	94ms
tests/utils/plugin_test.py::TestPluginLoader::test_load_plugins_remote_0__workspace_tests_utils_plugins	✅	13.2s
tests/utils/plugin_test.py::TestPluginLoader::test_load_plugins_remote_1_tests_utils_plugins	✅	11.6s
tests/utils/plugin_test.py::TestPluginLoader::test_passing_custom_class_0__workspace_tests_utils_plugins	✅	6.5s
tests/utils/plugin_test.py::TestPluginLoader::test_passing_custom_class_1_tests_utils_plugins	✅	5.9s
tests/utils/registry_test.py::TestRegistryWithRay::test_dynamic_import	✅	6.2s
tests/utils/registry_test.py::TestRegistry::test_algorithm_registry_mapping	✅	15ms
tests/utils/registry_test.py::TestRegistry::test_buffer_module_registry_mapping	✅	413ms
tests/utils/registry_test.py::TestRegistry::test_common_module_registry_mapping	✅	45ms
tests/utils/registry_test.py::TestRegistry::test_register_module	✅	1ms
tests/utils/registry_test.py::TestRegistry::test_utils_module_registry_mapping	✅	1ms
tests/utils/swanlab_test.py::TestSwanlabMonitor::test_swanlab_monitor_smoke	❌	2ms

Github Test Reporter by CTRF 💚

pan-x-c

others LGTM

pan-x-c · 2025-12-25T03:33:03Z

tests/utils/swanlab_test.py

+        cls.env_keys = ["SWANLAB_API_KEY", "SWANLAB_APIKEY", "SWANLAB_KEY", "SWANLAB_TOKEN"]
+        cls._original_env = {k: os.environ.get(k) for k in cls.env_keys}
+        if not any(os.getenv(k) for k in cls.env_keys):
+            os.environ["SWANLAB_API_KEY"] = "dummy_key_for_smoke_test"


change the key to avoid swanlab api key format check error

pan-x-c · 2025-12-25T03:34:17Z

trinity/utils/monitor.py

        }
+
+
+@MONITOR.register_module("swanlab")


Delete this line and register it directly in default_mapping like other monitor.

impl swanlab monitor

3f9f0e3

gemini-code-assist bot reviewed Dec 24, 2025

View reviewed changes

trinity/utils/monitor.py Show resolved Hide resolved

trinity/utils/monitor.py Show resolved Hide resolved

trinity/utils/monitor.py Show resolved Hide resolved

trinity/utils/monitor.py Outdated Show resolved Hide resolved

modelscope deleted a comment from gemini-code-assist bot Dec 24, 2025

binary-husky and others added 3 commits December 25, 2025 03:00

Update trinity/utils/monitor.py

78c7aa3

Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>

Update trinity/utils/monitor.py

0ed5969

Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>

Add unit tests for SwanlabMonitor functionality

841eb42

binary-husky requested a review from pan-x-c December 24, 2025 19:03

pan-x-c reviewed Dec 25, 2025

View reviewed changes

Refactor SwanlabMonitor test setup for improved environment handling

103c403

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

impl swanlab monitor #450

impl swanlab monitor #450

binary-husky commented Dec 24, 2025 •

edited

Loading

Uh oh!

gemini-code-assist bot commented Dec 24, 2025

Uh oh!

gemini-code-assist bot left a comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

pan-x-c Dec 25, 2025

Uh oh!

pan-x-c commented Dec 25, 2025

Uh oh!

github-actions bot commented Dec 25, 2025

Uh oh!

pan-x-c commented Dec 25, 2025

Uh oh!

github-actions bot commented Dec 25, 2025

Uh oh!

pan-x-c left a comment •

edited

Loading

Uh oh!

pan-x-c Dec 25, 2025

Uh oh!

pan-x-c Dec 25, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

		}


		@MONITOR.register_module("swanlab")

impl swanlab monitor #450

Are you sure you want to change the base?

impl swanlab monitor #450

Conversation

binary-husky commented Dec 24, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Uh oh!

gemini-code-assist bot commented Dec 24, 2025

Summary of Changes

Highlights

Footnotes

Uh oh!

gemini-code-assist bot left a comment

Choose a reason for hiding this comment

Code Review

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

pan-x-c Dec 25, 2025

Choose a reason for hiding this comment

Uh oh!

pan-x-c commented Dec 25, 2025

Uh oh!

github-actions bot commented Dec 25, 2025

Summary

Failed Tests

Tests

Uh oh!

pan-x-c commented Dec 25, 2025

Uh oh!

github-actions bot commented Dec 25, 2025

Summary

Failed Tests

Tests

Uh oh!

pan-x-c left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

pan-x-c Dec 25, 2025

Choose a reason for hiding this comment

Uh oh!

pan-x-c Dec 25, 2025

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

binary-husky commented Dec 24, 2025 •

edited

Loading

pan-x-c left a comment •

edited

Loading