Skip to content

fix(workflows): remove release-please skip guard that prevents tag creation #511

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
WilliamBerryiii merged 3 commits into from
Feb 13, 2026
+11 −12
Merged

fix(workflows): remove release-please skip guard that prevents tag creation #511

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
56a612e
fix(workflows): remove release-please skip guard that prevents tag cr…
WilliamBerryiii Feb 13, 2026
eacee02
fix(docs): address review comment and table formatting in workflows.md
WilliamBerryiii Feb 13, 2026
8691457
Merge branch 'main' into fix/release-please-skip-guard-510
WilliamBerryiii Feb 13, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion .github/workflows/main.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -64,7 +64,6 @@ jobs:

release-please:
name: Release Please
if: "${{ github.event_name != 'push' || !startsWith(github.event.head_commit.message, 'chore(main): release') }}"
needs:
- spell-check
- markdown-lint
Expand Down
22 changes: 11 additions & 11 deletions docs/architecture/workflows.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -136,20 +136,20 @@ flowchart LR
style RP fill:#f9f,stroke:#333
```

The release-please job includes a commit-message guard that skips execution when the head commit message starts with `chore(main): release`. This prevents an infinite loop where release-please-generated merge commits would re-trigger the release workflow.
Release-please v4 handles `chore`-type commits natively. They are not releasable and do not produce spurious release PRs, so no commit-message guard is needed.

### Main Branch Jobs

| Job | Purpose | Dependencies |
|---------------------------|--------------------------------|--------------------------------------------------|
| spell-check | Post-merge spelling validation | None |
| markdown-lint | Post-merge markdown validation | None |
| table-format | Post-merge table validation | None |
| dependency-pinning-scan | Security pinning check | None |
| pester-tests | PowerShell unit tests | None |
| release-please | Automated release management | All validation jobs (skipped on release commits) |
| extension-package-release | Build release VSIX | release-please (conditional) |
| attest-and-upload | Sign and upload VSIX | extension-package-release |
| Job | Purpose | Dependencies |
|---------------------------|--------------------------------|------------------------------|
| spell-check | Post-merge spelling validation | None |
| markdown-lint | Post-merge markdown validation | None |
| table-format | Post-merge table validation | None |
| dependency-pinning-scan | Security pinning check | None |
| pester-tests | PowerShell unit tests | None |
| release-please | Automated release management | All validation jobs |
| extension-package-release | Build release VSIX | release-please (conditional) |
| attest-and-upload | Sign and upload VSIX | extension-package-release |
Comment on lines +143 to +152
Copy link

Copilot AI Feb 13, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The “Main Branch Jobs” table no longer matches .github/workflows/main.yml: the workflow also includes plugin-package-release, upload-plugin-packages, and publish-release jobs, but they are not documented here. Please add the missing jobs (and ideally reflect them in the pipeline diagram/description) so the docs stay accurate.

Copilot uses AI. Check for mistakes.

When release-please creates a release, the `extension-package-release` job builds the VSIX with the correct version, and `attest-and-upload` signs it with Sigstore attestation before uploading to the GitHub Release.

Expand Down
Loading