Skip to content

Conversation

@WilliamBerryiii
Copy link
Member

Description

Removed a commit-message guard on the release-please job in the main branch workflow that prevented tag and release creation when release PR merges landed. Release-please v4 handles chore-type commits natively, making the guard unnecessary and harmful.

  • fix(workflows): removed the if condition on the release-please job in main.yml that skipped execution when the head commit started with chore(main): release, allowing createReleases() to run on release PR merges
  • docs(architecture): updated docs/architecture/workflows.md to explain that release-please v4 handles chore commits natively and removed the stale "(skipped on release commits)" note from the Main Branch Jobs table

Related Issue(s)

Fixes #510

Type of Change

Select all that apply:

Code & Documentation:

  • Bug fix (non-breaking change fixing an issue)
  • New feature (non-breaking change adding functionality)
  • Breaking change (fix or feature causing existing functionality to change)
  • Documentation update

Infrastructure & Configuration:

  • GitHub Actions workflow
  • Linting configuration (markdown, PowerShell, etc.)
  • Security configuration
  • DevContainer configuration
  • Dependency update

AI Artifacts:

  • Reviewed contribution with prompt-builder agent and addressed all feedback
  • Copilot instructions (.github/instructions/*.instructions.md)
  • Copilot prompt (.github/prompts/*.prompt.md)
  • Copilot agent (.github/agents/*.agent.md)
  • Copilot skill (.github/skills/*/SKILL.md)

Note for AI Artifact Contributors:

  • Agents: Research, indexing/referencing other project (using standard VS Code GitHub Copilot/MCP tools), planning, and general implementation agents likely already exist. Review .github/agents/ before creating new ones.
  • Skills: Must include both bash and PowerShell scripts. See Skills.
  • Model Versions: Only contributions targeting the latest Anthropic and OpenAI models will be accepted. Older model versions (e.g., GPT-3.5, Claude 3) will be rejected.
  • See Agents Not Accepted and Model Version Requirements.

Other:

  • Script/automation (.ps1, .sh, .py)
  • Other (please describe):

Testing

  • Ran npm run lint:md with 0 errors on changed files
  • Ran npx cspell with 0 issues on changed files
  • Validated all 24 workflow files with actionlint

Checklist

Required Checks

  • Documentation is updated (if applicable)
  • Files follow existing naming conventions
  • Changes are backwards compatible (if applicable)
  • Tests added for new functionality (if applicable)

Required Automated Checks

The following validation commands must pass before merging:

  • Markdown linting: npm run lint:md
  • Spell checking: npm run spell-check
  • Frontmatter validation: npm run lint:frontmatter
  • Link validation: npm run lint:md-links
  • PowerShell analysis: npm run lint:ps

Security Considerations

  • This PR does not contain any sensitive or NDA information
  • Any new dependencies have been reviewed for security issues
  • Security-related scripts follow the principle of least privilege

Additional Notes

Previously validated in Azure-Samples/azure-nvidia-robotics-reference-architecture (PR #175 / issue #174). The guard was originally added for release-please v3 loop prevention, which v4 handles internally by classifying chore commits as non-releasable.

🔧 - Generated by Copilot

…eation

- remove commit-message guard from release-please job in main.yml
- update docs/architecture/workflows.md to reflect v4 native handling
- remove stale '(skipped on release commits)' note from jobs table

Fixes #510

🐛 - Generated by Copilot
@WilliamBerryiii WilliamBerryiii requested a review from a team as a code owner February 13, 2026 03:07
Copilot AI review requested due to automatic review settings February 13, 2026 03:07
@github-actions
Copy link

github-actions bot commented Feb 13, 2026

Dependency Review

✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.

Scanned Files

None

@codecov-commenter
Copy link

codecov-commenter commented Feb 13, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 83.39%. Comparing base (67585f5) to head (eacee02).

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #511      +/-   ##
==========================================
- Coverage   83.41%   83.39%   -0.03%     
==========================================
  Files          20       20              
  Lines        3510     3510              
==========================================
- Hits         2928     2927       -1     
- Misses        582      583       +1     
Flag Coverage Δ
pester 83.39% <ø> (-0.03%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.
see 1 file with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR fixes an issue where the release-please job was being skipped on release-merge commits, which prevented tag and GitHub Release creation on merge to main. It removes the now-unnecessary guard (given release-please v4 behavior) and updates workflow documentation accordingly.

Changes:

  • Removed the commit-message if guard from the release-please job in the main branch workflow so releases/tags are created on release PR merges.
  • Updated workflow architecture documentation to reflect release-please v4 behavior and removed the outdated “skipped on release commits” note.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.

File Description
.github/workflows/main.yml Ensures release-please runs on release PR merge commits so tags/releases get created immediately.
docs/architecture/workflows.md Updates workflow documentation to match the new (and correct) release-please behavior.

- replace em dash with period per writing-style guidance
- hyphenate chore-type commits for grammar clarity
- fix table column alignment to pass table-format check

🔧 - Generated by Copilot
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

fix(workflows): release-please skip guard prevents tag creation on release merges

3 participants