-
Notifications
You must be signed in to change notification settings - Fork 47
fix(workflows): remove release-please skip guard that prevents tag creation #511
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
…eation - remove commit-message guard from release-please job in main.yml - update docs/architecture/workflows.md to reflect v4 native handling - remove stale '(skipped on release commits)' note from jobs table Fixes #510 🐛 - Generated by Copilot
Dependency Review✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.Scanned FilesNone |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #511 +/- ##
==========================================
- Coverage 83.41% 83.39% -0.03%
==========================================
Files 20 20
Lines 3510 3510
==========================================
- Hits 2928 2927 -1
- Misses 582 583 +1
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
This PR fixes an issue where the release-please job was being skipped on release-merge commits, which prevented tag and GitHub Release creation on merge to main. It removes the now-unnecessary guard (given release-please v4 behavior) and updates workflow documentation accordingly.
Changes:
- Removed the commit-message
ifguard from therelease-pleasejob in the main branch workflow so releases/tags are created on release PR merges. - Updated workflow architecture documentation to reflect release-please v4 behavior and removed the outdated “skipped on release commits” note.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
.github/workflows/main.yml |
Ensures release-please runs on release PR merge commits so tags/releases get created immediately. |
docs/architecture/workflows.md |
Updates workflow documentation to match the new (and correct) release-please behavior. |
- replace em dash with period per writing-style guidance - hyphenate chore-type commits for grammar clarity - fix table column alignment to pass table-format check 🔧 - Generated by Copilot
Description
Removed a commit-message guard on the release-please job in the main branch workflow that prevented tag and release creation when release PR merges landed. Release-please v4 handles
chore-type commits natively, making the guard unnecessary and harmful.ifcondition on therelease-pleasejob inmain.ymlthat skipped execution when the head commit started withchore(main): release, allowingcreateReleases()to run on release PR mergesdocs/architecture/workflows.mdto explain that release-please v4 handles chore commits natively and removed the stale "(skipped on release commits)" note from the Main Branch Jobs tableRelated Issue(s)
Fixes #510
Type of Change
Select all that apply:
Code & Documentation:
Infrastructure & Configuration:
AI Artifacts:
prompt-builderagent and addressed all feedback.github/instructions/*.instructions.md).github/prompts/*.prompt.md).github/agents/*.agent.md).github/skills/*/SKILL.md)Other:
.ps1,.sh,.py)Testing
npm run lint:mdwith 0 errors on changed filesnpx cspellwith 0 issues on changed filesactionlintChecklist
Required Checks
Required Automated Checks
The following validation commands must pass before merging:
npm run lint:mdnpm run spell-checknpm run lint:frontmatternpm run lint:md-linksnpm run lint:psSecurity Considerations
Additional Notes
Previously validated in
Azure-Samples/azure-nvidia-robotics-reference-architecture(PR #175 / issue #174). The guard was originally added for release-please v3 loop prevention, which v4 handles internally by classifyingchorecommits as non-releasable.🔧 - Generated by Copilot