Skip to content

feat: add CI/CD workflows for infrastructure validation#53

Closed
maxrantil wants to merge 4 commits intomasterfrom
feat/add-cicd-workflows
Closed

feat: add CI/CD workflows for infrastructure validation#53
maxrantil wants to merge 4 commits intomasterfrom
feat/add-cicd-workflows

Conversation

@maxrantil
Copy link
Owner

Summary

Adds 5 GitHub Actions workflows to validate infrastructure changes before merge. This closes the critical gap of having zero CI/CD for 607 lines of infrastructure code.

Workflows Added

1. Shell Quality (shell-quality.yml)

  • Validates: provision-vm.sh, destroy-vm.sh, test scripts
  • Tools: ShellCheck (syntax, best practices) + shfmt (formatting)
  • Triggers: PRs with **.sh or tests/** changes

2. Commit Format (commit-format.yml)

  • Validates: Conventional commit messages
  • Examples: feat:, fix:, docs:, refactor:
  • Triggers: All PRs

3. Session Handoff (verify-session-handoff.yml)

  • Validates: SESSION_HANDOVER.md updated per CLAUDE.md
  • Triggers: All PRs

4. PR Title Check (pr-title-check.yml)

  • Validates: PR titles follow conventional format
  • Triggers: PR open/edit/sync

5. Master Protection (protect-master.yml)

  • Blocks: Direct pushes to master
  • Enforces: PR workflow
  • Triggers: Pushes to master

Technical Details

All workflows use reusable workflows from maxrantil/.github@master:

  • shell-quality-reusable.yml
  • conventional-commit-check-reusable.yml
  • session-handoff-check-reusable.yml
  • pr-title-check-reusable.yml
  • protect-master-reusable.yml

Test Plan

  • Workflows created in .github/workflows/
  • All use @master branch reference
  • Pre-commit hooks passed (YAML syntax valid)
  • CI workflows run on this PR
  • ShellCheck validates provision-vm.sh
  • Commit format validated
  • PR title validated
  • Session handoff checked (if work complete)

Expected CI Time

  • ShellCheck: ~30 seconds
  • Commit validation: ~10 seconds
  • Session handoff: ~10 seconds
  • PR title: ~5 seconds
  • Total: <1 minute

Impact

Before: Infrastructure changes merged without validation
After: 5 automated checks prevent infrastructure breakage

Resolves

Closes #48 (or latest CI/CD issue number)

Part of Full Agents Audit implementation (Week 1 - CRITICAL priority)

Documentation

Will update README with CI/CD section in follow-up PR.


🤖 Generated with Claude Code

maxrantil and others added 3 commits October 10, 2025 15:13
Add 5 GitHub Actions workflows to validate infrastructure changes:
- shell-quality.yml: ShellCheck and shfmt for bash scripts
- commit-format.yml: Conventional commit validation
- verify-session-handoff.yml: Session handoff documentation check
- pr-title-check.yml: PR title format validation
- protect-master.yml: Block direct pushes to master

All workflows use reusable workflows from maxrantil/.github@master.

This closes the critical gap of having zero CI/CD validation for
607 lines of infrastructure code (Terraform, Ansible, bash scripts).

Resolves: #48 (or latest issue number)

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-Authored-By: Claude <noreply@anthropic.com>
Add 2 additional GitHub Actions workflows:
- block-ai-attribution.yml: Blocks PRs with AI tool attribution
- pre-commit-validation.yml: Runs pre-commit hooks in CI

This brings vm-infra to full parity with project-templates
standard workflow set (7 total workflows).

All workflows use reusable workflows from maxrantil/.github@master.

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-Authored-By: Claude <noreply@anthropic.com>
Add workflow to validate PR body/description for AI attribution,
completing the coverage alongside commit and issue checks.

Uses new pr-body-ai-attribution-check-reusable workflow from
maxrantil/.github (feature branch for testing).

Once the .github PR is merged, this will be updated to @master.
Now that the reusable workflow is merged to master in .github repo,
update the reference from feature branch to @master.
@maxrantil
Copy link
Owner Author

Closing PR as CI/CD implementation approach has changed. The workflows will be reintroduced through a different strategy.

@maxrantil maxrantil closed this Oct 10, 2025
@maxrantil maxrantil deleted the feat/add-cicd-workflows branch October 10, 2025 14:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

TEST-004: Add automated E2E test with --dry-run flag

1 participant