fix: apply 4-space indentation standard to all shell scripts#55
Closed
fix: apply 4-space indentation standard to all shell scripts#55
Conversation
Add 5 GitHub Actions workflows to validate infrastructure changes: - shell-quality.yml: ShellCheck and shfmt for bash scripts - commit-format.yml: Conventional commit validation - verify-session-handoff.yml: Session handoff documentation check - pr-title-check.yml: PR title format validation - protect-master.yml: Block direct pushes to master All workflows use reusable workflows from maxrantil/.github@master. This closes the critical gap of having zero CI/CD validation for 607 lines of infrastructure code (Terraform, Ansible, bash scripts). Resolves: #48 (or latest issue number) 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com>
Add 2 additional GitHub Actions workflows: - block-ai-attribution.yml: Blocks PRs with AI tool attribution - pre-commit-validation.yml: Runs pre-commit hooks in CI This brings vm-infra to full parity with project-templates standard workflow set (7 total workflows). All workflows use reusable workflows from maxrantil/.github@master. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com>
Add workflow to validate PR body/description for AI attribution, completing the coverage alongside commit and issue checks. Uses new pr-body-ai-attribution-check-reusable workflow from maxrantil/.github (feature branch for testing). Once the .github PR is merged, this will be updated to @master.
Now that the reusable workflow is merged to master in .github repo, update the reference from feature branch to @master.
maxrantil
force-pushed
the
fix/issue-54-shell-formatting
branch
from
66b35f6 to
4825b4c
Compare
maxrantil
changed the title
maxrantil
force-pushed
the
fix/issue-54-shell-formatting
branch
from
4825b4c to
8c4a626
Compare
Update CI workflow to use 4-space indentation standard. Apply shfmt formatting with -i 4 -ci -sr flags: - Add spaces around redirect operators (2> instead of 2>) - Consistent 4-space indentation - Case statement indentation - Simplified redirects Files formatted: - provision-vm.sh - destroy-vm.sh - tests/test_local_dotfiles.sh - tests/test_ansible_variables.sh - tests/test_ssh_key_validation.sh - .github/workflows/shell-quality.yml (updated to 4-space) All 66 tests still passing after formatting changes. Fixes #54
Owner
Author
|
Closing to consolidate commits. Reopening with clean single commit in new PR. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes shell formatting issues flagged by the new CI/CD workflows (PR #53). Applies shfmt formatting with
-i 4 -ci -srflags to all shell scripts.Fixes: #54
Priority: HIGH (blocking CI/CD implementation)
Changes Made
Formatting Applied
2> /dev/nullinstead of2>/dev/null)-srflagFiles Formatted
provision-vm.sh(97 changes)destroy-vm.shtests/test_local_dotfiles.shtests/test_ansible_variables.shtests/test_ssh_key_validation.shVerification
Local Testing
Pre-commit Hooks
✅ All pre-commit hooks passed
Expected CI Results
Impact
Related