Skip to content

Conversation

@TylerDurden-23
Copy link

No description provided.

@logicog
Copy link
Owner

logicog commented Jan 27, 2026

Really great first impression: it looks great and it immediately showed the config. This is a great idea!
Some comments:
I edited the config, and it is not clear to me, how the config relates to the settings above, i.e. the ip configuration. When I press the "Save Settings to Flash" button, what will be saved regarding the IP configuration, what will be the precedence?

My suggestion would be to have maybe a separation line between the update settings. Maybe an explanation that the settings are only saved to the runtime configuration of the device.

I also typed "ip" on the CLI and this ended up in the Configuration editor field like this:
image

The configuration should probably be taken from the flash, not from the command history. But the question is then how the runtime settings are taken into account. Probably the editor window should reflect the runtime settings. Maybe add an indicator "Currently Changed" so the user understands that this is the runtime, not the configuration in the flash? This is just an idea.

When I then updated the runtime settings and reloaded the page, I got the following config:
image

There is a filter function in config.js that filters a previous command out in order that only the last command of a certain cathegory remains, i.e. the second ip configuration overwrites the previous one. Have a look how it is done e.g. for the EEE configuration.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants