Skip to content

Conversation

@TylerDurden-23
Copy link

The current state visualization does not work - but this was the state before and needs a additional PR to apply the phy_to_log transformation for the vlan interface state.

@logicog logicog self-assigned this Jan 25, 2026
@logicog
Copy link
Owner

logicog commented Jan 26, 2026

Testet it and it works! I like the concept, too!

I am just wondering whether it would be possible to also add a feature that allows to set an arbitrary PVID for the ports. Maybe have an input field in which the PVID is set to the VID by default when a VID is selected.

Would that make sense?

At present we cannot set arbitrary PVIDs for a port.

@TylerDurden-23
Copy link
Author

TylerDurden-23 commented Jan 26, 2026

@logicog You can enter a VLANID and only select ports for PVID - this would basically do it.
Also for totally arbitrary configs, PR #102 is likely the better approach.

I would argue, that the current default is what is needed in 90% of cases - configure the VLAN - and enable the PVID for all untagged ports. That is what is done with this PR.

@logicog
Copy link
Owner

logicog commented Jan 26, 2026

That was not clear to my me. Maybe there could be a different message, something like this: "Use this VLAN as default for incoming traffic (PVID)"

@TylerDurden-23
Copy link
Author

Maybe this as a compromise between being clear and to verbose and out of line with the other labels.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants