Skip to content

Comments

Explicitly added current namespace to robot_description_parameter_client#134

Merged
nim65s merged 1 commit intoloco-3d:mainfrom
xmatousm:main
Feb 12, 2026
Merged

Explicitly added current namespace to robot_description_parameter_client#134
nim65s merged 1 commit intoloco-3d:mainfrom
xmatousm:main

Conversation

@xmatousm
Copy link

We are using LFC and the rest of nodes in a namespace (to be prepared for two robot setup). When LFC is started by ros_control on real hardware, the robot_description_parameter_client_ is created on the correct (same) namespace, requesting the robot_state_publisher server on the same namespace as well, so everything works as expected.

However, when running with gazebo, the LFC itself is correctly started in the requested namespace, but the robot_description_parameter_client_ is created in the root namespace, also requesting the publisher on the root namespace. Seems that there is inconsistencty in ros_gz_sim. The easiest fix to add the current namespace of LFC explicitly.

Copy link
Contributor

@nim65s nim65s left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks !

@xmatousm
Copy link
Author

So how to fix the failing checks?

@nim65s
Copy link
Contributor

nim65s commented Feb 10, 2026

we yeet the ros-tooling thing, as I already did few days ago in loco-3d/linear-feedback-controller-msgs#60
Reproducing this here was already on my todo list, so it should be done soon, sorry for the delay and inconvenience.

@nim65s
Copy link
Contributor

nim65s commented Feb 11, 2026

Ok, done in #136
Can you rebase your branch on main @xmatousm ?

@xmatousm xmatousm reopened this Feb 11, 2026
@nim65s nim65s merged commit ea297dc into loco-3d:main Feb 12, 2026
34 of 40 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants